-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable sharing statistics #11
Comments
Relatedly, this block seems to be related to the same functionality, this ticket should handle the todo here: numbers_api/public/js/script.js Lines 291 to 296 in f864c9b
|
Here is the new api. |
We should be able to replicate the functionality. However, we need to add a script to the deployed website so that the API can begin tracking shares / visits. The URL and script for this is below: URL: https://www.addthis.com/dashboard#get-the-code/pub/ra-5e4e232d004d763e Script: <script type="text/javascript" src="//s7.addthis.com/js/300/addthis_widget.js#pubid=ra-5e4e232d004d763e"></script> Until then, it probably does not make too much sense to write the functionality, as it will be hard to test functionality without website tracking data. Right now, we only get an empty array back from the API. |
@jacobson-ben in that case it may make sense to open a separate PR just to include this script tag, and then we go from there. I don't exactly remember the work flow for creating a new deploy but either @Nalipp or I can figure it out. eventually this will hopefully be handled by #12. |
There's a bunch of commented-out code here:
https://github.com/rithmschool/numbers_api/blob/master/app.js#L21-L39
and here:
https://github.com/rithmschool/numbers_api/blob/master/app.js#L48-L91
would be nice to add this back. Right now, there are a couple of problems:
The text was updated successfully, but these errors were encountered: