Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare buffered opcodes to current one at the same address #71

Open
Rot127 opened this issue Jul 21, 2022 · 0 comments
Open

Compare buffered opcodes to current one at the same address #71

Rot127 opened this issue Jul 21, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Rot127
Copy link
Member

Rot127 commented Jul 21, 2022

At https://github.com/rizinorg/rizin/blob/a689f0a86ee7218a12dc7ab5f00ff985d737019f/librz/asm/arch/hexagon/hexagon_arch.c#L780-L782

the asm plugin checks if an instruction at the given address is already buffered and returns it if so.
This can lead to incorrect textual disassembly if the opcode at this address changed and the instruction would be another than before.

The instruction should be disassembled again, if the buffered opcode doesn't match the given one.

@Rot127 Rot127 added the bug Something isn't working label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant