Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Still functions: #7

Open
jhihn opened this issue Mar 15, 2021 · 4 comments
Open

Missing Still functions: #7

jhihn opened this issue Mar 15, 2021 · 4 comments

Comments

@jhihn
Copy link

jhihn commented Mar 15, 2021

    void RaspiCam_Still::setShutterSpeed(unsigned int ss) {
        _impl->setShutterSpeed(ss);
    }
    void RaspiCam_Still::setAWB_RB(float red_g, float blue_g) {
        _impl->setAWB_RB(red_g, blue_g);
    }
@manalito
Copy link
Contributor

manalito commented Mar 15, 2021

I made an implementation of these functions. Based on my tests, it works as expected.
I've just created a new pull request : #9

@jhihn
Copy link
Author

jhihn commented Mar 16, 2021

This helps, but you only implemented the OpenCV side. Still, I was able yo follow your lead and get something working for Qt.

@manalito
Copy link
Contributor

This helps, but you only implemented the OpenCV side. Still, I was able yo follow your lead and get something working for Qt.

You can find here implementation of function on the C++ side : manalito@71ecf3a

I didn't updated the pull request since I am not quiet satisfied yet about the implementation. It's working but it surely requires a refactor of the code to have the same effect with both OpenCV and C++ functions.
I'll do it soon. Feel free to tell me any suggestions about the functions I wrote.

@jhihn
Copy link
Author

jhihn commented Mar 17, 2021

Excellent, I will check it out tomorrow. Wishing you had a tip jar! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants