Dynamic shortcuts defined as documents suggest will not work for iOS

[ccompton-ip]

Documentation states that dynamic shortcuts can be defined as below.

const shortcutItem = {
  id: 'my.awesome.action',
  title: 'Do awesome things',
  shortTitle: 'Do it',
  subtitle: 'iOS only',
  iconName: 'ic_awesome',
  symbolName: 'house.fill', // SF Symbol Name (iOS only)
  data: {
    foo: 'bar',
  },
};

This will throw an unexpected error on iOS

rn_quick_actions/Shortcuts.swift:29: Fatal error: 'try!' expression unexpectedly raised an error: rn_quick_actions.ShortcutsError.invalidShortcutItem

Because iOS requires the keys type and title.

    static func from(_ value: [String: Any]) throws -> UIApplicationShortcutItem? {
        guard
            let type = value["type"] as? String,
            let title = value["title"] as? String
            else {
                throw ShortcutsError.invalidShortcutItem
        }

        let subtitle = value["subtitle"] as? String
        let icon = UIApplicationShortcutIcon.from(value)
        let userInfo = value["data"] as? [String: NSSecureCoding]

        return UIApplicationShortcutItem(
            type: type,
            localizedTitle: title,
            localizedSubtitle: subtitle,
            icon: icon,
            userInfo: userInfo
        )
    }

Workaround would be to define the dynamic shortcut as

const shortcutItem = {
  type: 'my.awesome.action',
  title: 'Do awesome things',
  shortTitle: 'Do it',
  subtitle: 'iOS only',
  iconName: 'ic_awesome',
  symbolName: 'house.fill', // SF Symbol Name (iOS only)
  data: {
    foo: 'bar',
  },
};

Except this will break on Android as it expects a key of id. Android will fail silently and the shortcut will not appear when the app icon is long-pressed.

Defining dynamic shortcut as

const shortcutItem = {
  id: 'my.awesome.action',
  type: 'my.awesome.action',
  title: 'Do awesome things',
  shortTitle: 'Do it',
  subtitle: 'iOS only',
  iconName: 'ic_awesome',
  symbolName: 'house.fill', // SF Symbol Name (iOS only)
  data: {
    foo: 'bar',
  },
};

will work for both platforms but is prone to error.

Suggested fix is to standardize how a dynamic shortcut is defined on RN side, and do proper conversions in the bridging code for the respective platforms.