You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Having the exact same pattern between each installers would simplify maintenance. I have tested to copy terraform-installer.sh and search/replace any terraform reference by packer and it seems functional. I can make a PR with this change if you are interested in.
Bonus: the same Terraform installer works perfectly fine for nomad, vault and consul when the jq query is adapted. That would be a great addition to https://iac.sh :-D
The text was updated successfully, but these errors were encountered:
Great callout, @kral2 and I agree that using the same pattern for all the installers is ideal. (One of the main reasons I split them out was due to tag/release issues that you've identified.)
Does the the modified version you've tested work with Packer releases before 1.4.3? Since some folks use these scripts in CI pipelines to install pinned versions, we want to ensure that it still works with all versions.
I've also considered combining this into a universal Hashi installer (since the logic is mostly the same).
Update related to testing older version : Modified Installer works with all the way down to 0.10.2 (tested only on macOS whith packer version returning the expected version). Below that, a binary is downloaded (up to 0.1.0) but it appeared broken on macOS Big Sur. Can't test it.
terraform-installer uses GitHub releases whereas packer-installer uses tags.
Line 63 indicates that this choice was made because release was not populated at the time.
packer-installer/packer-install.sh
Line 63 in 476a5af
That is not the case anymore since v1.4.3.
Having the exact same pattern between each installers would simplify maintenance. I have tested to copy
terraform-installer.sh
and search/replace anyterraform
reference bypacker
and it seems functional. I can make a PR with this change if you are interested in.Bonus: the same Terraform installer works perfectly fine for nomad, vault and consul when the jq query is adapted. That would be a great addition to https://iac.sh :-D
The text was updated successfully, but these errors were encountered: