Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with config/Misleading comments #118

Open
ashler2 opened this issue Nov 6, 2024 · 0 comments
Open

Issue with config/Misleading comments #118

ashler2 opened this issue Nov 6, 2024 · 0 comments

Comments

@ashler2
Copy link

ashler2 commented Nov 6, 2024

On -

'expire_in' => 20, // number of minutes to expire cache/session

It says 'expire_in' => 20, // number of minutes to expire cache/session for the forrest override settings.
However looking at the config within the Forrest Page this config is in seconds - https://github.com/omniphx/forrest/blob/b9a62e2bd4d3b5e3ddfa779b93d1cf8c86e51b00/src/config/config.php#L70
'expire_in' => 3600, // number of seconds to expire cache/session

From what i can see this was a bug on the forrest side that was fixed. Is this correct or is this package is in seconds too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant