Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Crash when opening folder with subfolder called "Öffentlich" #20

Open
roblillack opened this issue Dec 4, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@roblillack
Copy link
Owner

No description provided.

@roblillack
Copy link
Owner Author

This seems to happen, because a custom Icon is searched for every file/dir name, stack:

  • char* GetFileImgName(char* fileName, enum FileType fileType) in files.c
  • char* FSGetStringForNameKey(char* name, char* key) in prop.c
  • WMPropList* FSGetUDObjectForKey(WMUserDefaults* database, char* defaultName) in prop.c
  • WMPropList* WMGetUDObjectForKey(WMUserDefaults *database, const char *defaultName) (in WINGs/WUtil)

There seems to be an issue with hashing UTF-8 keys in this function. The real fix is twofold: Fix the hash function in WINGs and make sure FSViewer does not try to load userdefaults for every file entry. I'll fix the latter here, it will probably still show up for files that contain umlauts in the extension ....

roblillack added a commit that referenced this issue Dec 4, 2024
* files: Fix crash with Umlaut dir entries on macOS. #20

* Add changelog entry
@roblillack roblillack added this to the 0.3 milestone Dec 4, 2024
@roblillack roblillack self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant