Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify in the readme how the save works in robometry #188

Open
Nicogene opened this issue Jan 8, 2024 · 0 comments
Open

Clarify in the readme how the save works in robometry #188

Nicogene opened this issue Jan 8, 2024 · 0 comments

Comments

@Nicogene
Copy link
Member

Nicogene commented Jan 8, 2024

          Actually, I believe that the problem is not in the number of samples, but a missing detail.

If you specify that you want to save 3 samples, robometry will save a file with three entries, even if you push 10 times. It will simply save the last three items. This behavior may not be properly specified in the README.

Moreover, if you enable the autosave option, it will create a new file every time you push 3 samples. Hence, when pushing 10, you should expect three files with 3 samples each, and 1 file with the last item (triggering the manual "save").

Also this might not be properly specified in the README.

By forcing the for loops to run fr three elements does not improve the clarity in this sense.

Another issue with the README is that in this line

bufferConfig.n_samples = n_samples;

n_samples should be substituted with 3.

Originally posted by @S-Dafarra in #187 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant