Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Scan class in db and fsbd #2

Open
jlegrand62 opened this issue Apr 3, 2020 · 1 comment
Open

Rename Scan class in db and fsbd #2

jlegrand62 opened this issue Apr 3, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jlegrand62
Copy link
Member

The name Scan is not appropriate:

  1. confusing with other classes named identically across the developed ROMI packages (tasks, configs...)
  2. it is not "only" a "scan" since it can be made of more than just one FileSet, it will also gather the task's outputs.

I would suggest ScanProject, Project, Dataset or ScanDataset.
Feel free to comment and propose other names!
@jlegrand62 jlegrand62 added enhancement New feature or request invalid This doesn't seem right and removed invalid This doesn't seem right labels Apr 3, 2020
@jlegrand62
Copy link
Member Author

Note that "projects" and/or "dataset" are commonly found in the database terminology.

@jlegrand62 jlegrand62 assigned jlegrand62 and unassigned jlegrand62 Apr 3, 2020
@hanappe hanappe added this to the future milestone May 7, 2020
@naittaleb naittaleb removed this from the future milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@naittaleb @jlegrand62 @hanappe