Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress lock file when running the plant-3d-explorer #68

Open
fabfabBesnard opened this issue May 24, 2022 · 1 comment
Open

Suppress lock file when running the plant-3d-explorer #68

fabfabBesnard opened this issue May 24, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@fabfabBesnard
Copy link
Collaborator

No description provided.

@fabfabBesnard fabfabBesnard added the enhancement New feature or request label May 24, 2022
@EvanZarrella
Copy link
Contributor

EvanZarrella commented Jun 8, 2022

I don't believe this is advised as it seems the dtw project (https://github.com/romi/dtw) is using this lock. It may cause issue when integrating plant-3d-explorer and plant-3d-vision.
Moreover, the database is not aware of what is connected to it, so treating specifically the case of the plant-3d-explorer would require implementing some kind of handshake between plantdb and any client for plantdb to know what to do with which client.
This seems to me that it would require a lot of work for seemingly no added benefits to the user.

If the problems comes from bundling the database when running plant-3d-explorer (eg in a zip file) a command such as zip bundle.zip <database> -x <database>/lock can be used.

On the other hand, if dtw removes its need for the lock, then it would be possible to remove the locking mechanism altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants