Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a friendly error message when rustc --print target-cpus is not supported #1

Open
ronnychevalier opened this issue Mar 4, 2023 · 0 comments
Open

Add a friendly error message when rustc --print target-cpus is not supported #1

ronnychevalier opened this issue Mar 4, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@ronnychevalier
Copy link
Owner

ronnychevalier commented Mar 4, 2023 •
edited
Loading

Depending on how rustc was built, rustc --print target-cpus can return an error ("Target CPU help is not supported by this LLVM version.").

See https://github.com/rust-lang/rust/blob/ee6533d7408f1447c028025c883a34c904d25ba4/compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp#L365 and rust-lang/rust#104785

We should catch this error and print a friendly error message to the user.
@ronnychevalier ronnychevalier added the good first issue Good for newcomers label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ronnychevalier