Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new release repositories: executive_smach #275

Closed
130s opened this issue Jun 12, 2023 · 5 comments · Fixed by #276
Closed

Add new release repositories: executive_smach #275

130s opened this issue Jun 12, 2023 · 5 comments · Fixed by #276
Labels
needs-rosdistro-source-link packages must be present in ros/rosdistro to demonstrate passing license and name review.

Comments

@130s
Copy link

130s commented Jun 12, 2023

  • Name of the release team:

Only @130s for now, no team. If someone can volunteer to join as a backup maintenance member that's great.

@130s
Copy link
Author

130s commented Jun 12, 2023

Honestly I didn't really understand what the issue template requires. Hope I've given all info requested...

@nuclearsandwich
Copy link
Collaborator

Honestly I didn't really understand what the issue template requires. Hope I've given all info requested...

Thank you for your efforts to complete the template. You did provide all of the necessary information and completed the template successfully.

If you would be willing to comment on #125 and let me know which parts were confusing or difficult to follow, it would help me improve the templates. Thanks!

Once the Humble source entry has been approved and merged, I will merge and deploy #276 to fulfill this request.

@nuclearsandwich nuclearsandwich added the needs-rosdistro-source-link packages must be present in ros/rosdistro to demonstrate passing license and name review. label Jun 13, 2023
@130s
Copy link
Author

130s commented Jun 14, 2023

Ok, posted feedback #125 (review)!

I like the idea of using PR's view, even after merge, for review (as long as it won't create confusion) :)

@nuclearsandwich
Copy link
Collaborator

In case I get lost today, the deployment of this PR was delayed because I hit the 5000 request rate limit after a few successive terraform plans. I should be updating within an hour confirming successful deployment but it's possible (given that it's Saturday) that time will get away from me while waiting.

@nuclearsandwich
Copy link
Collaborator

This change has been deployed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rosdistro-source-link packages must be present in ros/rosdistro to demonstrate passing license and name review.
Development

Successfully merging a pull request may close this issue.

2 participants