From 9760329210e8bf35f8b3a868cb651510d44e1d2f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Steven!=20Ragnar=C3=B6k?= Date: Wed, 31 Aug 2022 10:48:20 -0700 Subject: [PATCH 1/2] Add a reference to the new source entry requirement for ros2-gbp repository creation. As discussed, we're adding a requirement to the release repository creation process to add a source stanza, ensuring that the packages in the new repository undergo rosdistro review before a release repository is created. This is particularly important for naming convention review since that review could affect the name of the source, and by extension, release repository created. --- source/How-To-Guides/Releasing/Release-Team-Repository.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source/How-To-Guides/Releasing/Release-Team-Repository.rst b/source/How-To-Guides/Releasing/Release-Team-Repository.rst index d4be5350997..af613cb293c 100644 --- a/source/How-To-Guides/Releasing/Release-Team-Repository.rst +++ b/source/How-To-Guides/Releasing/Release-Team-Repository.rst @@ -61,6 +61,8 @@ Having a release repository separate from your source code repository is a requi Create a new release repository ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +If your repository is new to the ROS community, you should first open a pull request on `ros/rosdistro `_ adding a ``source`` entry for your repository. +The review process for the rosdistro database will ensure your repository and packages conform to the `REP 144 package naming conventions `_ and other requirements before release. Fill the `Add New Release Repositories issue `_ issue template if you don't have a release repo for your project yet. From 60e0128c72823fc84c41ddd50c41f7ec1fca78fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Steven!=20Ragnar=C3=B6k?= Date: Fri, 9 Sep 2022 13:29:32 -0700 Subject: [PATCH 2/2] Rephrase and clarify that you should *pass* review first. Co-authored-by: Chris Lalancette --- source/How-To-Guides/Releasing/Release-Team-Repository.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/How-To-Guides/Releasing/Release-Team-Repository.rst b/source/How-To-Guides/Releasing/Release-Team-Repository.rst index af613cb293c..7a90a0dce15 100644 --- a/source/How-To-Guides/Releasing/Release-Team-Repository.rst +++ b/source/How-To-Guides/Releasing/Release-Team-Repository.rst @@ -63,7 +63,7 @@ Create a new release repository If your repository is new to the ROS community, you should first open a pull request on `ros/rosdistro `_ adding a ``source`` entry for your repository. The review process for the rosdistro database will ensure your repository and packages conform to the `REP 144 package naming conventions `_ and other requirements before release. -Fill the `Add New Release Repositories issue `_ issue template +Once your package name has been approved and merged, fill in the `Add New Release Repositories issue `_ issue template if you don't have a release repo for your project yet. What if my existing release repo isn't on ros2-gbp?