Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post-0.0.1 code review #44

Closed
3 of 10 tasks
rsouth opened this issue Aug 23, 2020 · 0 comments
Closed
3 of 10 tasks

post-0.0.1 code review #44

rsouth opened this issue Aug 23, 2020 · 0 comments
Labels
stream of consciousness Thoughts and notes to be reviewed

Comments

@rsouth
Copy link
Owner

rsouth commented Aug 23, 2020 •
edited
Loading

Review the state so far, raise tickets and prioritise.

Mostly looking for

  • C++ issues, would like to learn more about C++14/17 features
  • Repetition (e.g. the string join which was moved to StringUtils)
  • encapsulation issues - sequencer.cpp is pretty heavy
  • commit the old set of unit tests and bring them up to date Unit tests #66
  • efficiency; lots of places where unnecessary copies are happening for example
  • caught exceptions which aren't handled Exception handling #67
  • unused old vars/methods
  • StringUtils::get_token_value isn't really re-usable, and had to re-read it's usage to understand
  • StringUtils::replace can return nullptr; don't think that's good?
  • RenderingUtils caching could use a re-working...

update; struck out issues to be ticketed seperately
@rsouth rsouth added the stream of consciousness Thoughts and notes to be reviewed label Aug 23, 2020
@rsouth rsouth closed this as completed Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stream of consciousness Thoughts and notes to be reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rsouth