From 77cf2e284ea0630758409ecbb70f9391bf6ec53c Mon Sep 17 00:00:00 2001 From: Bjoern Rudner Date: Tue, 27 Aug 2024 16:53:01 +0200 Subject: [PATCH 1/7] prepare for iTop 3.1 --- README.md | 4 ++++ ...r-costcenter-bridge-for-br-peripherals.php | 22 ------------------- ...r-costcenter-bridge-for-br-peripherals.php | 12 +++++----- ...-peripherals-bridge-for-teemip-ip-mgmt.php | 2 +- ...-peripherals-bridge-for-teemip-ip-mgmt.php | 2 +- ...-peripherals-bridge-for-teemip-ip-mgmt.php | 22 ------------------- ...-peripherals-bridge-for-teemip-ip-mgmt.php | 10 ++++----- .../de.dict.br-peripherals.php | 2 +- .../en.dict.br-peripherals.php | 2 +- br-peripherals/model.br-peripherals.php | 22 ------------------- br-peripherals/module.br-peripherals.php | 8 +++---- extension.xml | 4 ++-- 12 files changed, 22 insertions(+), 90 deletions(-) delete mode 100644 br-costcenter-bridge-for-br-peripherals/model.br-costcenter-bridge-for-br-peripherals.php rename br-peripherals-bridge-for-teemip-ip-mgmt/{ => dictionaries}/de.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php (95%) rename br-peripherals-bridge-for-teemip-ip-mgmt/{ => dictionaries}/en.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php (95%) delete mode 100644 br-peripherals-bridge-for-teemip-ip-mgmt/model.br-peripherals-bridge-for-teemip-ip-mgmt.php rename br-peripherals/{ => dictionaries}/de.dict.br-peripherals.php (98%) rename br-peripherals/{ => dictionaries}/en.dict.br-peripherals.php (98%) delete mode 100644 br-peripherals/model.br-peripherals.php diff --git a/README.md b/README.md index 2a8f054..38f8fd7 100644 --- a/README.md +++ b/README.md @@ -11,6 +11,10 @@ Adds monitor, docking station, keyboard, mouse, headset * iTop End-User Devices (itop-endusers-devices/2.7.5) needs to be enabled during setup +## iTop Compatibility + +The extension was tested on iTop 2.7.11 + ## Attribution This Extension uses Icons from: diff --git a/br-costcenter-bridge-for-br-peripherals/model.br-costcenter-bridge-for-br-peripherals.php b/br-costcenter-bridge-for-br-peripherals/model.br-costcenter-bridge-for-br-peripherals.php deleted file mode 100644 index bf8bd1d..0000000 --- a/br-costcenter-bridge-for-br-peripherals/model.br-costcenter-bridge-for-br-peripherals.php +++ /dev/null @@ -1,22 +0,0 @@ - 'Bridge - Costcenter + Periperals', @@ -18,17 +18,15 @@ // Setup 'dependencies' => array( - 'br-costcenter/0.1.0', - 'br-peripherals/0.6.0', + 'br-costcenter/0.4.0', + 'br-peripherals/0.6.1', ), 'mandatory' => false, 'visible' => true, // To prevent auto-install but shall not be listed in the install wizard 'auto_select' => 'SetupInfo::ModuleIsSelected("br-costcenter") && SetupInfo::ModuleIsSelected("br-peripherals")', // Components - 'datamodel' => array( - 'model.br-costcenter-bridge-for-br-peripherals.php' - ), + 'datamodel' => array(), 'webservice' => array(), 'dictionary' => array(), 'data.struct' => array(), diff --git a/br-peripherals-bridge-for-teemip-ip-mgmt/de.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php b/br-peripherals-bridge-for-teemip-ip-mgmt/dictionaries/de.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php similarity index 95% rename from br-peripherals-bridge-for-teemip-ip-mgmt/de.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php rename to br-peripherals-bridge-for-teemip-ip-mgmt/dictionaries/de.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php index 6645430..33eb6dc 100644 --- a/br-peripherals-bridge-for-teemip-ip-mgmt/de.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php +++ b/br-peripherals-bridge-for-teemip-ip-mgmt/dictionaries/de.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php @@ -3,7 +3,7 @@ /** * @copyright Copyright (C) 2024 Björn Rudner * @license https://www.gnu.org/licenses/gpl-3.0.en.html - * @version 2024-08-16 + * @version 2024-08-27 * * Localized data */ diff --git a/br-peripherals-bridge-for-teemip-ip-mgmt/en.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php b/br-peripherals-bridge-for-teemip-ip-mgmt/dictionaries/en.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php similarity index 95% rename from br-peripherals-bridge-for-teemip-ip-mgmt/en.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php rename to br-peripherals-bridge-for-teemip-ip-mgmt/dictionaries/en.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php index 1b9cde9..1bd3809 100644 --- a/br-peripherals-bridge-for-teemip-ip-mgmt/en.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php +++ b/br-peripherals-bridge-for-teemip-ip-mgmt/dictionaries/en.dict.br-peripherals-bridge-for-teemip-ip-mgmt.php @@ -3,7 +3,7 @@ /** * @copyright Copyright (C) 2024 Björn Rudner * @license https://www.gnu.org/licenses/gpl-3.0.en.html - * @version 2024-08-16 + * @version 2024-08-27 * * Localized data */ diff --git a/br-peripherals-bridge-for-teemip-ip-mgmt/model.br-peripherals-bridge-for-teemip-ip-mgmt.php b/br-peripherals-bridge-for-teemip-ip-mgmt/model.br-peripherals-bridge-for-teemip-ip-mgmt.php deleted file mode 100644 index fb58382..0000000 --- a/br-peripherals-bridge-for-teemip-ip-mgmt/model.br-peripherals-bridge-for-teemip-ip-mgmt.php +++ /dev/null @@ -1,22 +0,0 @@ - false, 'visible' => true, // To prevent auto-install but shall not be listed in the install wizard @@ -31,9 +31,7 @@ // Components // - 'datamodel' => array( - 'model.br-peripherals-bridge-for-teemip-ip-mgmt.php' - ), + 'datamodel' => array(), 'data.struct' => array(), 'data.sample' => array(), diff --git a/br-peripherals/de.dict.br-peripherals.php b/br-peripherals/dictionaries/de.dict.br-peripherals.php similarity index 98% rename from br-peripherals/de.dict.br-peripherals.php rename to br-peripherals/dictionaries/de.dict.br-peripherals.php index ee0ad0e..ef2e683 100644 --- a/br-peripherals/de.dict.br-peripherals.php +++ b/br-peripherals/dictionaries/de.dict.br-peripherals.php @@ -3,7 +3,7 @@ /** * @copyright Copyright (C) 2024 Björn Rudner * @license https://www.gnu.org/licenses/gpl-3.0.en.html - * @version 2024-08-16 + * @version 2024-08-27 * * Localized data */ diff --git a/br-peripherals/en.dict.br-peripherals.php b/br-peripherals/dictionaries/en.dict.br-peripherals.php similarity index 98% rename from br-peripherals/en.dict.br-peripherals.php rename to br-peripherals/dictionaries/en.dict.br-peripherals.php index 6237585..4d76459 100644 --- a/br-peripherals/en.dict.br-peripherals.php +++ b/br-peripherals/dictionaries/en.dict.br-peripherals.php @@ -3,7 +3,7 @@ /** * @copyright Copyright (C) 2024 Björn Rudner * @license https://www.gnu.org/licenses/gpl-3.0.en.html - * @version 2024-08-09 + * @version 2024-08-27 * * Localized data */ diff --git a/br-peripherals/model.br-peripherals.php b/br-peripherals/model.br-peripherals.php deleted file mode 100644 index bf8bd1d..0000000 --- a/br-peripherals/model.br-peripherals.php +++ /dev/null @@ -1,22 +0,0 @@ - array( - 'model.br-peripherals.php' - ), + 'datamodel' => array(), 'webservice' => array(), 'data.struct' => array(), 'data.sample' => array(), diff --git a/extension.xml b/extension.xml index c62f181..624db5e 100644 --- a/extension.xml +++ b/extension.xml @@ -16,10 +16,10 @@ - + - + From 6b2191906b19030c375b15b8fe15781921fad275 Mon Sep 17 00:00:00 2001 From: Bjoern Rudner Date: Tue, 27 Aug 2024 17:13:37 +0200 Subject: [PATCH 2/7] change dependencies --- br-peripherals/module.br-peripherals.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/br-peripherals/module.br-peripherals.php b/br-peripherals/module.br-peripherals.php index bb43d39..0082a5a 100644 --- a/br-peripherals/module.br-peripherals.php +++ b/br-peripherals/module.br-peripherals.php @@ -21,7 +21,7 @@ // 'dependencies' => array( '(itop-config-mgmt/2.5.0 & itop-config-mgmt/<3.0.0)||itop-structure/3.0.0', - 'itop-endusers-devices/2.7.5', + 'itop-endusers-devices/2.7.5||itop-endusers-devices/3.0.0', ), 'mandatory' => false, 'visible' => true, From 8e5666cb49fb1af1b6546e7e9705e0467ca34016 Mon Sep 17 00:00:00 2001 From: Bjoern Rudner Date: Tue, 27 Aug 2024 17:14:09 +0200 Subject: [PATCH 3/7] update visual representation --- README.md | 2 +- br-peripherals/datamodel.br-peripherals.xml | 61 ++++++++++++++------- 2 files changed, 43 insertions(+), 20 deletions(-) diff --git a/README.md b/README.md index 38f8fd7..68cf5e3 100644 --- a/README.md +++ b/README.md @@ -9,7 +9,7 @@ Adds monitor, docking station, keyboard, mouse, headset ## Dependencies -* iTop End-User Devices (itop-endusers-devices/2.7.5) needs to be enabled during setup +* iTop End-User Devices (itop-endusers-devices) needs to be enabled during setup ## iTop Compatibility diff --git a/br-peripherals/datamodel.br-peripherals.xml b/br-peripherals/datamodel.br-peripherals.xml index 9637637..11dc91f 100644 --- a/br-peripherals/datamodel.br-peripherals.xml +++ b/br-peripherals/datamodel.br-peripherals.xml @@ -19,7 +19,12 @@ - + + status + + images/usb-hub.png @@ -216,7 +221,12 @@ - + + status + + images/monitor.png @@ -226,8 +236,6 @@ - -
@@ -409,7 +417,12 @@ - + + status + + images/keyboard.png @@ -419,8 +432,6 @@ - -
@@ -602,7 +613,12 @@ - + + status + + images/mouse.png @@ -612,8 +628,6 @@ - -
@@ -795,7 +809,12 @@ - + + status + + images/headset.png @@ -805,8 +824,6 @@ - -
@@ -988,7 +1005,12 @@ - + + status + + images/scanner.png @@ -998,8 +1020,6 @@ - -
@@ -1181,7 +1201,12 @@ - + + status + + images/barcode-scanner.png @@ -1191,8 +1216,6 @@ - -
From cb4c53b9cb79422c4294b72773ec2db4a44df5c7 Mon Sep 17 00:00:00 2001 From: Bjoern Rudner Date: Tue, 27 Aug 2024 17:41:43 +0200 Subject: [PATCH 4/7] make MobilePhone and IPPhone look pretty --- ...r-costcenter-bridge-for-br-peripherals.xml | 56 +++++ br-peripherals/datamodel.br-peripherals.xml | 196 ++++++++++++++++++ 2 files changed, 252 insertions(+) diff --git a/br-costcenter-bridge-for-br-peripherals/datamodel.br-costcenter-bridge-for-br-peripherals.xml b/br-costcenter-bridge-for-br-peripherals/datamodel.br-costcenter-bridge-for-br-peripherals.xml index f5f4bb2..b27a34c 100644 --- a/br-costcenter-bridge-for-br-peripherals/datamodel.br-costcenter-bridge-for-br-peripherals.xml +++ b/br-costcenter-bridge-for-br-peripherals/datamodel.br-costcenter-bridge-for-br-peripherals.xml @@ -187,5 +187,61 @@ + + +
+ + + + + + + + 5 + + + + + + +
+ + + + + 160 + + + +
+
+ + +
+ + + + + + + + 5 + + + + + + +
+ + + + + 140 + + + +
+
diff --git a/br-peripherals/datamodel.br-peripherals.xml b/br-peripherals/datamodel.br-peripherals.xml index 11dc91f..e2889c3 100644 --- a/br-peripherals/datamodel.br-peripherals.xml +++ b/br-peripherals/datamodel.br-peripherals.xml @@ -1383,6 +1383,202 @@ + + +
+ + + + + + + + + + + + + + + + + + + 10 + + + 10 + + + 10 + + + 20 + + + 30 + + + 40 + + + 50 + + + + + 20 + + + 10 + + + 20 + + + 30 + + + 40 + + + 50 + + + 80 + + + 90 + + + + + + + 20 + + + 10 + + + 10 + + + 20 + + + 30 + + + + + 20 + + + 10 + + + + + + +
+
+
+ + +
+ + + + + + + + + + + + + + + + + 10 + + + 10 + + + 10 + + + 20 + + + 30 + + + 40 + + + 50 + + + + + 20 + + + 10 + + + 20 + + + 30 + + + 80 + + + 90 + + + + + + + 20 + + + 10 + + + 10 + + + 20 + + + 30 + + + + + 20 + + + 10 + + + + + + +
+
+
From da0f66ef3c7a372e2d9fd34a8d02fb3d23a3518a Mon Sep 17 00:00:00 2001 From: Bjoern Rudner Date: Tue, 27 Aug 2024 17:50:11 +0200 Subject: [PATCH 5/7] move position of MAC address and IP address --- ...-peripherals-bridge-for-teemip-ip-mgmt.xml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/br-peripherals-bridge-for-teemip-ip-mgmt/datamodel.br-peripherals-bridge-for-teemip-ip-mgmt.xml b/br-peripherals-bridge-for-teemip-ip-mgmt/datamodel.br-peripherals-bridge-for-teemip-ip-mgmt.xml index e3622c5..3dc6024 100644 --- a/br-peripherals-bridge-for-teemip-ip-mgmt/datamodel.br-peripherals-bridge-for-teemip-ip-mgmt.xml +++ b/br-peripherals-bridge-for-teemip-ip-mgmt/datamodel.br-peripherals-bridge-for-teemip-ip-mgmt.xml @@ -91,5 +91,53 @@ + + +
+ + + + + + + + + 24 + + + 25 + + + + + + +
+
+
+ + +
+ + + + + + + + + 24 + + + 25 + + + + + + +
+
+
From a54d3761308ae99c67d2ccc59ea423a038922b7e Mon Sep 17 00:00:00 2001 From: Bjoern Rudner Date: Tue, 27 Aug 2024 17:55:30 +0200 Subject: [PATCH 6/7] change positions of fields --- ...datamodel.br-peripherals-bridge-for-teemip-ip-mgmt.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/br-peripherals-bridge-for-teemip-ip-mgmt/datamodel.br-peripherals-bridge-for-teemip-ip-mgmt.xml b/br-peripherals-bridge-for-teemip-ip-mgmt/datamodel.br-peripherals-bridge-for-teemip-ip-mgmt.xml index 3dc6024..bddcc44 100644 --- a/br-peripherals-bridge-for-teemip-ip-mgmt/datamodel.br-peripherals-bridge-for-teemip-ip-mgmt.xml +++ b/br-peripherals-bridge-for-teemip-ip-mgmt/datamodel.br-peripherals-bridge-for-teemip-ip-mgmt.xml @@ -102,10 +102,10 @@ - 24 + 61 - 25 + 62 @@ -126,10 +126,10 @@ - 24 + 61 - 25 + 62 From f92fbd1d57ed8bc0732f96ef23efeb3acdbb3d9c Mon Sep 17 00:00:00 2001 From: Bjoern Rudner Date: Tue, 27 Aug 2024 17:58:01 +0200 Subject: [PATCH 7/7] compatibility with iTop 3.1 / set version to 0.7.0 --- README.md | 2 +- .../module.br-costcenter-bridge-for-br-peripherals.php | 4 ++-- .../module.br-peripherals-bridge-for-teemip-ip-mgmt.php | 4 ++-- br-peripherals/module.br-peripherals.php | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 68cf5e3..5bcd49a 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ Adds monitor, docking station, keyboard, mouse, headset ## iTop Compatibility -The extension was tested on iTop 2.7.11 +The extension was tested on iTop 2.7.11 and 3.1.1 ## Attribution diff --git a/br-costcenter-bridge-for-br-peripherals/module.br-costcenter-bridge-for-br-peripherals.php b/br-costcenter-bridge-for-br-peripherals/module.br-costcenter-bridge-for-br-peripherals.php index 64a85a1..b3474bc 100644 --- a/br-costcenter-bridge-for-br-peripherals/module.br-costcenter-bridge-for-br-peripherals.php +++ b/br-costcenter-bridge-for-br-peripherals/module.br-costcenter-bridge-for-br-peripherals.php @@ -10,7 +10,7 @@ SetupWebPage::AddModule( __FILE__, // Path to the current file, all other file names are relative to the directory containing this file - 'br-costcenter-bridge-for-br-peripherals/0.6.1', + 'br-costcenter-bridge-for-br-peripherals/0.7.0', array( // Identification 'label' => 'Bridge - Costcenter + Periperals', @@ -19,7 +19,7 @@ // Setup 'dependencies' => array( 'br-costcenter/0.4.0', - 'br-peripherals/0.6.1', + 'br-peripherals/0.7.0', ), 'mandatory' => false, 'visible' => true, // To prevent auto-install but shall not be listed in the install wizard diff --git a/br-peripherals-bridge-for-teemip-ip-mgmt/module.br-peripherals-bridge-for-teemip-ip-mgmt.php b/br-peripherals-bridge-for-teemip-ip-mgmt/module.br-peripherals-bridge-for-teemip-ip-mgmt.php index 5e94594..620a6e6 100644 --- a/br-peripherals-bridge-for-teemip-ip-mgmt/module.br-peripherals-bridge-for-teemip-ip-mgmt.php +++ b/br-peripherals-bridge-for-teemip-ip-mgmt/module.br-peripherals-bridge-for-teemip-ip-mgmt.php @@ -10,7 +10,7 @@ SetupWebPage::AddModule( __FILE__, - 'br-peripherals-bridge-for-teemip-ip-mgmt/0.6.1', + 'br-peripherals-bridge-for-teemip-ip-mgmt/0.7.0', array( // Identification // @@ -23,7 +23,7 @@ 'itop-endusers-devices/2.7.0', 'teemip-ip-mgmt/3.0.1', 'teemip-config-mgmt-adaptor/3.0.1', - 'br-peripherals/0.6.1', + 'br-peripherals/0.7.0', ), 'mandatory' => false, 'visible' => true, // To prevent auto-install but shall not be listed in the install wizard diff --git a/br-peripherals/module.br-peripherals.php b/br-peripherals/module.br-peripherals.php index 0082a5a..d8e90b3 100644 --- a/br-peripherals/module.br-peripherals.php +++ b/br-peripherals/module.br-peripherals.php @@ -10,7 +10,7 @@ SetupWebPage::AddModule( __FILE__, // Path to the current file, all other file names are relative to the directory containing this file - 'br-peripherals/0.6.1', + 'br-peripherals/0.7.0', array( // Identification //