-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datetime.datetime issue #55
Comments
You can find my plugin here: https://gitlab.com/cosminadrianpopescu/plugin.video.invidious Your plugin is called in file |
HI there |
The datetime.datetime issue can easy catched by including at line 62 in YoutubeDLWrapper.py
|
Yes, of course. But again: what are the implications? I can have a pull request with this, if you think that this is ok. |
I know that you can abbretivave the use of datetime.datetime.function with
so you end with datetime.strptime() instead of datetime.datetime.strptime(). May be there's some import statement anywhere. The fix don't touch the behavior of the original code so this can be included without side effects. I know that a lot of people have a missfunction of youtube.dl (Attribute error whitin the Kodi logs), others for some reasons don't. Including the fix work for both. I suggest you make a pull request. |
I'm trying to use
script.module.youtube.dl
in my own plugin like this:addon.xml
And then in my python file:
This will give me an error in
YoutubeDLWrapper.py
at line 62:In
YoutubeDLWrapper.py
, at line 62 there is this:If I replace this with
Then it will be fine. I will get the info of the movie.
I didn't created a pull request because I don't know exactly why you have there
datetime.datetime
. I don't know what other implications are there. I don't use your plugin in any other way. But if you think that this wouldn't impact anything else, I can also open a pull request.Thank you.
The text was updated successfully, but these errors were encountered: