-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disconnect handler is never called #2
Comments
I'm seeing this too. On disconnect, usually the first sign is that the call to Pull request #6 addresses this. |
My pull request works in the case where the connection is actively interrupted (eg the computer's ethernet cable is yanked or the wifi connection drops out). It doesn't address the case where the network is interrupted further upstream, because the library implements no timeouts / deadlines. I'll work up a pull request to address this. |
still not working? |
From what I've been able to gather, the disconnect handler is never getting called, and I'm assuming because there's no actual reconnecting support, the connection will basically end up in a "bad state", where it thinks it's still connected.
The text was updated successfully, but these errors were encountered: