-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protocol to the url, if not specified. #14
Labels
Comments
sounds good |
Pull request for the same. |
and also a minor validation for url, |
@ogheneovo12 yeah, we can add that as well |
@sam0hack can we add hacktoberfest label to this issue ? |
Sure |
@sam0hack can you please add the same ? |
Sure will do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Shall we add protocol to the Url, if not added by the user ?
Would be good user experience, instead of exception which gets thrown currently.
(node:64947) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Protocol error (Page.navigate): Cannot navigate to invalid URL (node:64947) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
If sounds appropriate, can you please assign this task to me ?
The text was updated successfully, but these errors were encountered: