Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protocol to the url, if not specified. #14

Open
sanchitgupta001 opened this issue Oct 2, 2020 · 8 comments
Open

Add protocol to the url, if not specified. #14

sanchitgupta001 opened this issue Oct 2, 2020 · 8 comments
Assignees
Labels

Comments

@sanchitgupta001
Copy link
Contributor

sanchitgupta001 commented Oct 2, 2020

Shall we add protocol to the Url, if not added by the user ?

Would be good user experience, instead of exception which gets thrown currently.

(node:64947) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Protocol error (Page.navigate): Cannot navigate to invalid URL (node:64947) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

If sounds appropriate, can you please assign this task to me ?

@sam0hack
Copy link
Owner

sam0hack commented Oct 2, 2020

sounds good

@sanchitgupta001
Copy link
Contributor Author

#16

Pull request for the same.

@ogheneovo12
Copy link
Contributor

and also a minor validation for url,

@sanchitgupta001
Copy link
Contributor Author

@ogheneovo12 yeah, we can add that as well

@sanchitgupta001
Copy link
Contributor Author

sanchitgupta001 commented Oct 3, 2020

@sam0hack can we add hacktoberfest label to this issue ?

@sam0hack
Copy link
Owner

sam0hack commented Oct 3, 2020

@sam0hack can we add hacktoberfest label to this issue ?

Sure

@sanchitgupta001
Copy link
Contributor Author

@sam0hack can you please add the same ?
I am unable to add it, may be some missing permission.

@sam0hack
Copy link
Owner

sam0hack commented Oct 3, 2020

Sure will do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants