Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating hardcoded timezone lists in source code #14

Open
nartc opened this issue Jan 28, 2019 · 0 comments
Open

Updating hardcoded timezone lists in source code #14

nartc opened this issue Jan 28, 2019 · 0 comments

Comments

@nartc
Copy link

nartc commented Jan 28, 2019

As #10 #13 mentioned, there's a problem with guess property being set to true. Now, the problem is not the property itself but the "outdated" timezones list in the source code.

The library depends on moment-timezone for the "guess" functionality but probably not keeping up-to-date with moment-timezone in terms of what moment-timezone returns for its .guess() method. This leads to this line: this.countryChange.emit(this.allTimezones.find(x => x.zones.indexOf(this.currentTimezone) >= 0).iso); errors out as this.allTimezones.find(x => x.zones.indexOf(this.currentTimezone) >= 0).iso is undefined.

Is there any update/suggestion to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant