Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup #759

Open
3 tasks
joncameron opened this issue Jan 10, 2025 · 0 comments
Open
3 tasks

Code Cleanup #759

joncameron opened this issue Jan 10, 2025 · 0 comments

Comments

@joncameron
Copy link
Contributor

joncameron commented Jan 10, 2025

Description

Code cleanup after the work for AVAnnotate functionality in Ramp is complete.

Done Looks Like

  • Refactoring as desired to clean up Ramp code after AV Annotate work is completed
    • duplication in the code where annotations are read and parsed into a list of items to be displayed in the UI. Both transcript component and annotations component read supplementing annotations from the Manifest in 2 different places. This could probably be read once by one of the components and stored in global state to be used by components as needed.
    • cleanup the code where the markers display and annotations display branches off in the MarkersDisplay component. Use displayMotivations prop to assist in the playlist marker parsing. Try to integrate the parsing markers into annotations-parser module by using displayMotivations prop value?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant