From ec2a0ad6ca1bc3963ac5de7e8214ccf91bb9f64b Mon Sep 17 00:00:00 2001
From: Peter Cai <222655+pcai@users.noreply.github.com>
Date: Thu, 6 Jun 2024 15:51:48 -0400
Subject: [PATCH] Upgrade rubyntlm, re-enable ntlm tests (#247)

---
 httpi.gemspec                         | 2 +-
 spec/httpi/adapter/httpclient_spec.rb | 3 +--
 spec/integration/net_http_spec.rb     | 9 +++------
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/httpi.gemspec b/httpi.gemspec
index 8930694..9a0bdab 100644
--- a/httpi.gemspec
+++ b/httpi.gemspec
@@ -26,7 +26,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'base64'
   s.add_dependency 'mutex_m'
 
-  s.add_development_dependency 'rubyntlm', '~> 0.3.2'
+  s.add_development_dependency 'rubyntlm', '~> 0.6.4'
   s.add_development_dependency 'rake',     '~> 13.0'
   s.add_development_dependency 'rspec',    '~> 3.5'
   s.add_development_dependency 'mocha',    '~> 0.13'
diff --git a/spec/httpi/adapter/httpclient_spec.rb b/spec/httpi/adapter/httpclient_spec.rb
index 88815ba..41e1b5d 100644
--- a/spec/httpi/adapter/httpclient_spec.rb
+++ b/spec/httpi/adapter/httpclient_spec.rb
@@ -215,8 +215,7 @@
     end
   end
 
-  # TODO: ntlm_openssl3 https://github.com/WinRb/rubyntlm/issues/57
-  xit "supports NTLM authentication" do
+  it "supports NTLM authentication" do
     request = HTTPI::Request.new(@server.url + "ntlm-auth")
 
     request.auth.ntlm("tester", "vReqSoafRe5O")
diff --git a/spec/integration/net_http_spec.rb b/spec/integration/net_http_spec.rb
index 63b689f..e9a9ccb 100644
--- a/spec/integration/net_http_spec.rb
+++ b/spec/integration/net_http_spec.rb
@@ -138,8 +138,7 @@
         to raise_error(HTTPI::NotSupportedError, /does not support HTTP digest authentication/)
     end
 
-    # TODO: ntlm_openssl3 https://github.com/WinRb/rubyntlm/issues/57
-    xit "supports ntlm authentication" do
+    it "supports ntlm authentication" do
       request = HTTPI::Request.new(@server.url + "ntlm-auth")
       request.auth.ntlm("tester", "vReqSoafRe5O")
 
@@ -167,8 +166,7 @@
       HTTPI::Adapter::NetHTTP.any_instance.unstub(:check_net_ntlm_version!)
     end
 
-    # TODO: ntlm_openssl3 https://github.com/WinRb/rubyntlm/issues/57
-    xit "does check ntlm when ntlm authentication is requested" do
+    it "does check ntlm when ntlm authentication is requested" do
       request = HTTPI::Request.new(@server.url + "ntlm-auth")
       request.auth.ntlm("tester", "vReqSoafRe5O")
 
@@ -185,8 +183,7 @@
       HTTPI::Adapter::NetHTTP.any_instance.unstub(:ntlm_version)
     end
 
-    # TODO: ntlm_openssl3 https://github.com/WinRb/rubyntlm/issues/57
-    xit "does not crash when authenticate header is missing (on second request)" do
+    it "does not crash when authenticate header is missing (on second request)" do
       request = HTTPI::Request.new(@server.url + "ntlm-auth")
       request.auth.ntlm("tester", "vReqSoafRe5O")