-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gradient/ laplacian supervision #2
Comments
I have not tried to implement this supervision, so I'm not sure how it will happen. According to the paper, section 3.2 of the appendix:
And also:
But I could not find how they calculate the gradient of the Siren output. It's worthy taking a look at other implementations, and see if anyone got this working. If you find anything please link it here. |
i was thinking to use torch.autograd.grad with only_inputs=True, but i never used this feature and it seems you need to call it N times otherwise RuntimeError: grad can be implicitly created only for scalar outputs. there is also a "jacobian" function, will keep you informed if i find how to do it. |
i did a first version just with numerical gradient (not the complicated autodiff stuff yet)
it more or less learns the image (when you train without the rgb supervision) up to a constant. it does not really seem to help when combined. |
ok so you also learn with a "numerical gradient right? (output prediction for all pixels and run sobel filtering on it before comparing it to ground truth) |
Yeah, I compare the numerical gradient of the network output against the ground truth. The official implementation is out, and they use autograd to calculate the networks gradients. |
hello, thanks for this implementation. how would you go about implementing the gradient or laplacian supervision? i wonder if it is involving the gradient of the network directly or some sort of sobel filtering over outputs (sample patches instead of pixels?), which would be much less elegant i guess?
The text was updated successfully, but these errors were encountered: