Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate using crc32 instead of md5 #557

Open
azazellochg opened this issue Sep 23, 2024 · 0 comments
Open

investigate using crc32 instead of md5 #557

azazellochg opened this issue Sep 23, 2024 · 0 comments
Assignees

Comments

@azazellochg
Copy link
Member

We could switch from md5 to crc32 (zlib.crc32 in python) checksums for test data. The main reason would be speed improvement when running tests. crc32 was designed to check for disk write errors/network errors which is what we want. There's no need for cryptographic md5 which is more secure but slower.

@azazellochg azazellochg self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant