Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections #506

Open
NicoLaval opened this issue Jul 7, 2024 · 5 comments · May be fixed by #537
Open

Collections #506

NicoLaval opened this issue Jul 7, 2024 · 5 comments · May be fixed by #537

Comments

@NicoLaval
Copy link
Collaborator

Is t := "A" in { "a", TEST };, where test is a variable defined previously, correct?

That is, should collections only contain constants or can they also contain variables?

@NicoLaval
Copy link
Collaborator Author

According to G4 file:

lists:
    GLPAREN  constant (COMMA constant)*  GRPAREN
;

constant:
    INTEGER_CONSTANT
    | NUMBER_CONSTANT
    | BOOLEAN_CONSTANT
    | STRING_CONSTANT
    | NULL_CONSTANT
;

Values has to be constant. Is there a problem if we extend this definition to variables?

@hadrienk
Copy link

hadrienk commented Jul 7, 2024

This should probably be changed to accept expressions indeed.

@antonio-olleros
Copy link

I agree!

@linardian
Copy link
Collaborator

I agree too! So please @NicoLaval fix the grammar to accept also set/valedomain identifiers. Thanks!

@NicoLaval NicoLaval linked a pull request Jan 26, 2025 that will close this issue
@NicoLaval
Copy link
Collaborator Author

Please see #537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants