[Bug] Ill-alignment of file type and saved/unsaved icons

[memeplex]

Thank you for the bug report

• I am using the latest version of doom-mode related packages.
• I checked FAQ.
• You may also try reproduce the issue using clean environment and minimal configurations with
  the command emacs -Q.

Bug description

Steps to reproduce

1. Use the default doom-modeline settings
2. Open a .txt file (other files will do it, but the issue is easier to spot comparing squared icons).
3. Do some changes.

Expected behavior

Better vertical alignment, specially for two icons that are together.

OS

MacOS

Emacs Version

28

Emacs Configurations

Custom

Error callstack

No response

Anything else

No response

[memeplex]

This is another case that looks terrible:

Maybe it's the file type icon the one to blame.

[seagle0128]

It's not possible to align all icons. doom-modeline leverages all-the-icons to display. You may need to file an issue for all-the-icons.

[memeplex]

Indeed I'd already done that (see domtronn/all-the-icons.el#287) but it seems to be something else going on here. Please take a look at that report. I was experiencing a similar issue with company-box that I was able to work around by changing the default adjust/raise property of the fonts as suggested in all-the-icons documentation (I still believe that their default is not the best, but I'm waiting for their response). Anyway, that didn't change anything for doom-modeline so apparently there is something hardcoded somewhere.

[memeplex]

Also, see how well aligned these two icons are:

There seems to be something specifically related to the alignment of the major mode icon.

[memeplex]

I'm closing this, I've learnt the hard way how difficult it is to get all font icons properly aligned, I don't think it's worth the effort and would like to see a gradual move to svg icons, no only in doom-modeline but across the ecosystem, now that emacs is built with rsvg by default, IMO that will be a saner approach than the current mishmash of icons that are not only different sized but also not very well supported by emacs (for example, string-width often fails to compute the right width as described in #478 (comment)).