Multiple languages maybe?

[martin6982]

Hi @seerge I come from Taiwan and I'm so happy to find this app on reddit, do you have a plan to make G-helper have mutiple languages? I think I can help the translation about the part of "Traditional Chinese" and maybe "Simplified Chinese". Maybe my coding experience is not good enough, but I can try my best.

also, I have a request that if I can introduce this app to the forum"https://www.gamer.com.tw/" which is the most popular gaming forum in Taiwan, because I found that G-Helper isn't well known between Mandarin users in Taiwan or China, we are also struggle in the issue about thermal, performance, and so on. I think this app will help Mandarin users a lot. Of course I will indicate you as the original author and share the app with your github link, please let me know if you are willing to agree that, thank you so much!

[seerge]

Hello @martin6982 , glad that you like the app.

Actually it has been just translated to Simplified Chinese - https://github.com/seerge/g-helper/releases/tag/v0.50 (feel free to try)

Also readme exists in Chinese too https://github.com/seerge/g-helper/blob/main/docs/README.zh-CN.md

And sure - you can introduce the app to more users, just don't forget a link to this github page.

[seerge]

Ok

[seerge]

@martin6982 pushed live in https://github.com/seerge/g-helper/releases/tag/v0.52

[martin6982]

great!

[martin6982]

Hi @seerge, I just finished my post on the forum I mentioned before, though you might not speak Chinese, It's still my pleasure to share with you! here is the link : https://forum.gamer.com.tw/C.php?bsn=60030&snA=622942

[seerge]

@martin6982 that's a long post! thanks for the effort

[martin6982]

Hi @seerge I just updated the "Strings.zh-TW" file on the github code editor page, but I am not sure if you can see that(It's my first time using the function), can you check that out?

[martin6982]

@seerge here is the v0.70 translation:
https://drive.google.com/file/d/1oDtJJnlhu1n4FISvInzI5eDGLYv826nF/view?usp=drive_link
thanks!

[martin6982]

@seerge here is the v0.75 translation:
https://drive.google.com/file/d/1OD_QnQD7sB-k0YOf2s8Q8kFGP96-YJ8k/view?usp=drive_link
thanks!

[martin6982]

@seerge here is the v0.78 translation:
https://drive.google.com/file/d/1nZxKnaYQ1WyxLj2ukEdrKrMoTg-1yjiQ/view?usp=drive_link
thanks!

[martin6982]

@seerge here is the v0.79 translation:
https://drive.google.com/file/d/1dvvxyOpM9FYIJ4FXz4X1xtlzmoX2YjtR/view?usp=drive_link
thanks!

[martin6982]

@seerge here is the v0.82 translation:
https://drive.google.com/file/d/1tBiXiXLitTLMuQqTP2Zm9GbkooZb2xZI/view?usp=drive_link
thanks!

[JesusJMUJI]

I'm using the app, and it's taking the Windows language, as you said on this thread. However, is there another way of setting the app language without changing the entire OS language?

[JesusJMUJI]

Hi. @JesusJMUJI I am sorry that the translation might be bad for you. The translation hasn't been done with a translator. "Exit" and "Quit" are two different things. I leave "Quit" as "Quitar" because it definitely "quits" the pogram (closes completely). "Exit" as "Salir" could be seen as closing the window for someone. I tried to leave the translation with the closest meaning to the original English without exceeding on words (that is an important one). Can you provide more examples of bad translation?

Also, I don't know if you are spanish from Spain or from Latin America. Note that some words look better on Latin Spanish than on Castillian Spanish or vice versa...

I am a native spanish, currently a Professor at an uni in Spain, teaching Economics in Enghish.... Additionally, I had some other work and project experiences in English. That is the reason that I felt confident to do this translation.

I speak Castillian Spanish, what you have done is called a "false friend" as you might know. The right translation is "Salir" as you are "exiting" the program.

I haven't been able to check the program to its fullest, so I cannot say if there are any more mistranslations.

Still, I commend you for the labor of translating it even if you are not a native. My English isn't perfect either.

Also, this is very off-topic, but it would be a coincidence if we were at the same university.

[marcelomijas]

No offenses taken :)

As I said, because my experience I felt confident about translating, but I am aware that I can have mistakes too. Can you provide more examples of bad translation? I could be wrong and/or it might be room for improvement...

[seerge]

Just in case https://github.com/seerge/g-helper/blob/main/app/Properties/Strings.es.resx this is a file containing all strings for spanish

[JesusJMUJI]

Just in case https://github.com/seerge/g-helper/blob/main/app/Properties/Strings.es.resx this is a file containing all strings for spanish

Many thanks, I'll take a look when I have some free time.

[JesusJMUJI]

No, currently it takes language from system locale on startup. Why would you want different language from your system ?

One more question @seerge, would be a problem if I open an issue about this? So, it can be considered as a new feature?

[marcelomijas]

@JesusJMUJI I disagree in this case... at the beginning I also thinked about translating it to "Salir", but again, I know a lot of people that this might be confusing. I understand that Exit a program is closing the window (but it might be running in the background), but quitting (Quitar) is closing it completely.

About the off topic: URJC or Complutense? (I teach officially on the first and help a group on the second) XD

[marcelomijas]

@seerge Yeah, that was the most complicated part, the shortening of labels. @JesusJMUJI I am writing comments on the PR. Some things are ok, like changing "Perfil" to "Curva", but be aware that Armoury Crate uses the word "Perfil" for the custom fans tool (at least in the 2020 G14)... but it is ok. :)

In contrast, other things are... well, look at the comments...

[seerge]

@marcelomijas and right - generally rule of thumb should be calling things same as they are called in AC ;) to simplify migration

[JesusJMUJI]

Sure thing, I'm cancelling the pull request for now. I need more experience before doing any of this, or at least asking beforehand.
I'm thankful for the input, too.

[marcelomijas]

I made all the comments @JesusJMUJI . Thank you!

@seerge I also see that the Spanish file has changed a little bit with some new field additions, Number of rows doesn't match with the English Strings.resx I will try to make the Spanish one complete today at night.

[seerge]

@marcelomijas yeah, mainly cause of added checkboxes in Extra (for Strix models) and some other stuff, i just don't want to bother translators every time :)

[TomBonnot]

Might be a weird question but :

• Where do I change language ? I want to use GHelper with my own traduction hehe
• Since I have done a fork of your project, will I have to do another fork later if I want to change new strings ? It’s my first time using fork haha so I am kinda curious !
  Anyway, that is cool, I think I will work on a fr and pt translation about the README(if it is useful, since I guess everyone can understand English)

[seerge]

@TomBonnot only in your system, app will pick it up. If you are debugging via visual studio -> also here https://github.com/seerge/g-helper/blob/020a7d074fd6501fec5688eb2e0077076debf388/app/Program.cs#LL45C19-L45C19 (uncomment line and set language)

You can either update your existing fork or create a new one, it doesn't matter

I wouldn't rush with translating README, as it changes :) + it's much bigger than any set of labels in the app