Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specifiy a container and a default component to load when stream is not ready #16

Open
nmondon opened this issue Sep 12, 2017 · 2 comments
Open

Allow to specifiy a container and a default component to load when stream is not ready #16

nmondon opened this issue Sep 12, 2017 · 2 comments
Assignees
@nmondon
Labels
enhancement

Comments

@nmondon
Copy link
Member

nmondon commented Sep 12, 2017

No description provided.

@nmondon nmondon self-assigned this Sep 12, 2017
@nmondon
Copy link
Member Author

nmondon commented Sep 26, 2017

The container is really not needed as we currently don't have a container...

OK for the default component, which can be replaced by a startWith value in the combinator observable but it's not convenient

nmondon added a commit that referenced this issue Sep 26, 2017
@nmondon
add a default component (#16)
08172d0
nmondon added a commit that referenced this issue Sep 26, 2017
@nmondon
default component (#18)
c063067 
* add a default component (#16)

* 4.0.0
@nmondon
Copy link
Member Author

nmondon commented Sep 26, 2017 •
edited
Loading

ok, not tested yet,
also, we should add a key="waiting" in order to enable nice transitions as react-addons-css-transition-group is waiting for a key

@nmondon nmondon closed this as completed Jan 21, 2018
@nmondon nmondon reopened this Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmondon nmondon

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nmondon