This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
forked from barosl/homu
-
Notifications
You must be signed in to change notification settings - Fork 49
Non-servo PRs regularly trigger "RuntimeError('Invalid configuration')" #176
Comments
When I run |
Somehow state.try_choose is invalid in this block. |
Possibly the cc @Manishearth |
Yeah try_choose is 0 for some reason for PRs like servo/heapsize#101 . Seems random? |
bors-servo
pushed a commit
that referenced
this issue
Nov 9, 2018
Use None, not False, for try_choose default value False gets stored as 0 fixes #176 I also ran `update table pull set try_choose=null where try_choose=0;` on the database to clean up things affected by this. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/177) <!-- Reviewable:end -->
yshui
pushed a commit
to hadeaninc/homu
that referenced
this issue
Apr 1, 2019
False gets stored as 0 fixes servo#176
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is coming from a PR in webrender that was approved. The code in question gathers up builders when a PR is approved and throws if no builders are applicable. This is a regression from the try-chooser work for reasons that are unclear to me.
The text was updated successfully, but these errors were encountered: