Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Minor interface improvements for Steam Deck users. #2086

Open
1 task done
GHU7924 opened this issue Jan 7, 2025 · 7 comments
Open
1 task done

Comments

@GHU7924
Copy link

GHU7924 commented Jan 7, 2025

Checklist

  • I have searched for a similar issue in this repository and did not find one.

Description

Resizing the window and improving the functions of the "Save" button in the "Patches" window for ease of use by Steam Deck users.

Reason

For more convenient use of the emulator in game mode on Steam Deck.

Examples

At the moment, hovering over different interface elements causes the window to change its size depending on the description. It might be worth adding 5 lines to the default description (I don't think I've seen more). In game mode, the windows look like this.

sdi

As for the "Patches" window, it looks like this.

20250107153739_1

As you may have noticed, the window frame is cut off in game mode. I can close this window through the Steam menu, but it would be more convenient if the "Close" button was added or the "Save" button was changed to "Save & Exit" (that is, the window was closed after saving).

P.S. If anyone else wants to comment on improving the emulator interface in Steam Deck game mode, then please add this information, perhaps I don't know something or haven't come across it.

@tomboylover93
Copy link
Contributor

I use Bazzite on my main computer, which includes Steam Deck Gaming Mode, so I could test these issues for myself and fix them. That, and the Settings window needs some reorganizing.

@GHU7924
Copy link
Author

GHU7924 commented Jan 8, 2025

I also noticed that the AutoUpdater window also has a slight size change. It seems to happen after clicking the "Update" button.

@tomboylover93
Copy link
Contributor

Can you send a screenshot for comparison?

@GHU7924
Copy link
Author

GHU7924 commented Jan 8, 2025

@tomboylover93 I'm apologize.
In fact, it's perfectly acceptable there, you can ignore it. I took screenshots of all the steps to make sure of this.
I remember that there were some changes, but they turned out to be completely insignificant.
20250108165304_1
20250108165316_1
20250108165442_1
20250108165755_1

@GHU7924
Copy link
Author

GHU7924 commented Jan 8, 2025

But thanks to this, I have a questions.
@DanielSvoboda When the update process is started, we can no longer cancel it? Can we improve it? Or is there a reason why it works that way?
Or at least add the visual effect that the "No" button is locked and cannot be pressed.

@tomboylover93
Copy link
Contributor

I could not figure out how to add more lines to the Settings window's text box and stop it from resizing the whole window, but I do have this working:

Screencast_20250108_185748.mp4

I'll make a PR for it shortly. It'll be a draft while I figure out which option in Qt Creator is responsible for setting a fixed height for QTextEdit widgets, as merely setting the "Vertical Policy" to "Fixed" doesn't seem to do anything.

@tomboylover93
Copy link
Contributor

I figured out what causes the window to change its size, and it was this section in settings_dialog.cpp:

Screenshot_20250108_200418

I removed it entirely, changed the Vertical Policy to Fixed, extended the text box's height to 110px and the whole window's height to 800px to accommodate for that, and now it looks like this:

Screencast_20250108_200319.mp4

You can see from the bottom that the text box no longer resizes back to the default of 70px when I hover over something with a smaller description text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants