Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing imperial volume units #375

Closed
bsidhom opened this issue Feb 23, 2024 · 3 comments · Fixed by #382
Closed

Missing imperial volume units #375

bsidhom opened this issue Feb 23, 2024 · 3 comments · Fixed by #382

Comments

@bsidhom
Copy link

bsidhom commented Feb 23, 2024

The prelude does not seem to include the imperial fluid ounce, imperial pint, imperial gallon, etc., but does have the US customary counterparts.

It would be nice to add these definitions, but I'm not sure how to deal with naming. We should try to avoid confusion as much as possible.

Note that this is unrelated to #116; I'm talking about individual unit definitions differing between US Customary and British Imperial. As far as I'm aware, this discrepancy only exists in volume units, but I'm not sure.

@sharkdp
Copy link
Owner

sharkdp commented Feb 24, 2024

It would be nice to add these definitions

👍

but I'm not sure how to deal with naming. We should try to avoid confusion as much as possible.

I suggest we follow Qalculates naming here, which has imperial_ prefixes for long unit names and UK_ prefixes for short unit names. For example:

imperial_gallon
UK_gal

@bsidhom
Copy link
Author

bsidhom commented Feb 24, 2024

Re: #382: after reading up on this, I just discovered that there's the customary tablespoon and "metric tablespoon" (15 mL exactly): https://en.wikipedia.org/wiki/Tablespoon. They apparently use metric tbsp in the UK. Not sure if this is worth adding or where to put it. Nobody appears to call it an "imperial tablespoon". There's a similar situation for the teaspoon.

@sharkdp
Copy link
Owner

sharkdp commented Feb 24, 2024

I just discovered that there's the customary tablespoon and "metric tablespoon" (15 mL exactly): https://en.wikipedia.org/wiki/Tablespoon. They apparently use metric tbsp in the UK. Not sure if this is worth adding or where to put it. Nobody appears to call it an "imperial tablespoon". There's a similar situation for the teaspoon.

Can you please open a new ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants