Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor TreeNode::group_nodes_below #804

Open
shawnlaffan opened this issue Nov 16, 2021 · 1 comment
Open

refactor TreeNode::group_nodes_below #804

shawnlaffan opened this issue Nov 16, 2021 · 1 comment
Labels
Refactor Code needs to be refactored

Comments

@shawnlaffan
Copy link
Owner

shawnlaffan commented Nov 16, 2021

TreeNode::group_nodes_below is pretty complex for what it does.

It might be possible to refactor it using a Schwartzian transform style approach where the bounds and node ref are stored in an array of arrays. That in turn might need a binary search approach if we keep things in sorted order, which might slow things down.

@shawnlaffan shawnlaffan added the Refactor Code needs to be refactored label Nov 16, 2021
@shawnlaffan
Copy link
Owner Author

Initial updates have been done as part of #803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Code needs to be refactored
Projects
None yet
Development

No branches or pull requests

1 participant