Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Old Style Casts #3

Closed
shinra-electric opened this issue Jan 28, 2024 · 1 comment
Closed

[Build] Old Style Casts #3

shinra-electric opened this issue Jan 28, 2024 · 1 comment

Comments

@shinra-electric
Copy link
Owner

shinra-electric commented Jan 28, 2024

When building directly from the RPCS3 repository, compilation will fail with many old-style-cast errors.

This is a known issue and is being tracked here.

The workaround is to suppress these warnings, but a proper fix is required.

Currently the script will pull from my own RPCS3 fork, pull updates from the upstream branch, and apply the workaround.

In the short term, I plan to at least inject the workarounds using the script, so it will work directly from the official RPCS3 repo and my fork won't be required anymore.

Update:
Currently the script will apply the workaround to suppress the warnings into the source code. An upstream fix for the underlying issue is still preferred.

@shinra-electric
Copy link
Owner Author

This has been fixed in the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant