Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Automatic release README update needs to be fixed #1601

Closed
1 task done
SaschaSchwarze0 opened this issue May 14, 2024 · 4 comments · Fixed by #1609
Closed
1 task done

[BUG] Automatic release README update needs to be fixed #1601

SaschaSchwarze0 opened this issue May 14, 2024 · 4 comments · Fixed by #1609
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@SaschaSchwarze0
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Kubernetes Version

No response

Shipwright Version

No response

Current Behavior

See #1562 (review). We need to fix the README manually, and fix the automation to also bump the additional place (and more ?).

Expected Behavior

No response

Steps To Reproduce

No response

Anything else?

No response

@SaschaSchwarze0 SaschaSchwarze0 added the kind/bug Categorizes issue or PR as related to a bug. label May 14, 2024
@SaschaSchwarze0
Copy link
Member Author

@adambkaplan you mentioned "a few" spots. If you know of more already, pls post them here. Tyia.

@qu1queee qu1queee added this to the release-v0.14.0 milestone May 16, 2024
@qu1queee qu1queee added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels May 16, 2024
@qu1queee
Copy link
Contributor

@adambkaplan to provide more insights on the details for fixing this one.

@Redeltaz
Copy link
Contributor

I think maybe it's about the curl line inside the README.md file, which was added on this commit. This line also display the release tag, but is not included inside the workfow that update all the tags of the README doc with the new version. So the curl line doesn't get updated by the workflow, which I suppose is the "few spots" mentionned by @adambkaplan.

The workflow only update the https://github.com/shipwright-io/build/.... URL, but the curl line use a https://raw.githubusercontent.com/shipwright-io/build/... which is not included inside the workflow as I said

I'm interested to work on this issue if it's possible and if my deductions are correct :)

@qu1queee
Copy link
Contributor

@Redeltaz thanks for the interest, please go ahead, if something needs to be change we can discuss that on your PR. By the way, we have a slack channel as well, to get in contact with folks faster, see here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants