Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return a messaging service in the PackEncryptedMetadata #127

Open
dbluhm opened this issue Sep 20, 2023 · 0 comments
Open

Always return a messaging service in the PackEncryptedMetadata #127

dbluhm opened this issue Sep 20, 2023 · 0 comments

Comments

@dbluhm
Copy link

dbluhm commented Sep 20, 2023

As implemented, calling pack_encrypted with the to DID not requiring forwarding will cause the returned PackEncryptedMetadata to omit the messaging_service parameter.

I suggest always returning the messaging_service parameter, even when forwarding is not required because not returning it requires me to rewrite routines already implemented by this library to determine the service endpoint to deliver my message to. It's not terribly complicated but it creates an opportunity for subtle discrepancies in implementation resulting in potentially inconsistent behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant