Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOCIL fork choice changes #6802

Open
2 tasks
michaelsproul opened this issue Jan 14, 2025 · 3 comments
Open
2 tasks

FOCIL fork choice changes #6802

michaelsproul opened this issue Jan 14, 2025 · 3 comments
Assignees
@eserilev
Labels
focil Fork choice enforced inclusion lists work-in-progress PR is a work-in-progress

Comments

@michaelsproul
Copy link
Member

Description

  • Import valid IL's & equivocating IL's to the fork choice store
  • Handle unsatisfied_inclusion_list_block logic
@michaelsproul michaelsproul added the focil Fork choice enforced inclusion lists label Jan 14, 2025
@michaelsproul michaelsproul added the work-in-progress PR is a work-in-progress label Jan 14, 2025
@michaelsproul michaelsproul mentioned this issue Jan 14, 2025
Open
20 tasks
@michaelsproul
Copy link
Member Author

I think the spec may be missing changes to get_proposer_head. It seems like (on time) IL-invalid blocks would not actually get reorged, because there are no changes to the proposer's choice of head to build upon. Currently the single-slot reorg strat only kicks in when the block is late.

We should probably raise a spec issue for this.

@michaelsproul
Copy link
Member Author

Case of two IL-invalid blocks in a row is also a bit strange with my understanding of get_attester_head, which always nominates the parent of the LMD-GHOST head

@michaelsproul
Copy link
Member Author

Asked these questions here: https://discord.com/channels/595666850260713488/1210529202458071050/1328595006877077534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eserilev eserilev

Labels
focil Fork choice enforced inclusion lists work-in-progress PR is a work-in-progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @eserilev