Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with pushgateway not exposing /metrics/job/... #502

Open
geofholbrook opened this issue May 26, 2022 · 3 comments
Open

Compatibility with pushgateway not exposing /metrics/job/... #502

geofholbrook opened this issue May 26, 2022 · 3 comments

Comments

@geofholbrook
Copy link

geofholbrook commented May 26, 2022

The push methods require a jobName and POST/PUT to the endpoint /metrics/job/<jobName>. This makes it incompatible with Gravel Gateway (https://github.com/sinkingpoint/prometheus-gravel-gateway), possibly other gateways that don't expose this endpoint.

Perhaps it would be appropriate to not require the jobName, and simply push to /metrics if it is not supplied? Or, implement some kind of override. I'd be happy to make a PR if we can agree on the appropriate interface.

@SimenB
Copy link
Collaborator

SimenB commented Aug 23, 2022

@zbjornson thoughts on this one?

@vkhytskyi-allegro
Copy link

Hello 👋🏼 Any updates on that? At my company we have just faced the same challenge and for us it is necessary to be able to override the target endpoint.

@geofholbrook
Copy link
Author

I created a PR to address this issue: #597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants