Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Builds #148

Closed
GuySartorelli opened this issue Oct 26, 2023 · 2 comments
Closed

Broken Builds #148

GuySartorelli opened this issue Oct 26, 2023 · 2 comments
Labels

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 26, 2023

silverstripe/framework 4.13 (and 4) phpunit

Also broken in kitchen sink, and various other builds which run framework CI.

  1. SilverStripe\Forms\Tests\HTMLEditor\HTMLEditorFieldTest::testFieldConfigSanitization
    Table is removed
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
-'<p>standard text</p><table><th><tr><td>Header</td></tr></th><tbody></tbody></table>'
+'<p>standard text</p><table><th></th><tr><td>Header</td></tr><tbody></tbody></table>'

/home/runner/work/silverstripe-framework/silverstripe-framework/tests/php/Forms/HTMLEditor/HTMLEditorFieldTest.php:268
/home/runner/work/silverstripe-framework/silverstripe-framework/vendor/bin/phpunit:122

PR

@GuySartorelli
Copy link
Member Author

PR merged. Reassigning back to Sabina to ensure builds go green.

@sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova removed their assignment Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants