Broken builds in 5.0

[GuySartorelli]

dnadesign/silverstripe-elemental

https://github.com/silverstripe/silverstripe-elemental/actions/runs/4997726484/jobs/8952788887

And a "page" "Blocks Page" with a "Alice's Block" content element with "original content" content # DNADesign\Elemental\Tests\Behat\Context\FixtureContext::theHasAContentElementWithContent()
Page is invalid (SilverStripe\ORM\ValidationException)

Basically, the configuration that applies ValidationFailedExtension to Page in the previous scenario either isn't being removed or a flush isn't being conducted after it is removed. This is a change from CMS 4 where that test passes fine.

Tag the module after this is fixed.

PR

• FIX Correctly clear extensions after each scenario silverstripe-behat-extension#241

[GuySartorelli]

git bisect says this was caused by silverstripe/silverstripe-elemental#1032
Most likely because of the base class change for fixture context.

[GuySartorelli]

In SilverStripe\BehatExtension\Context\FixtureContext::iAddAnExtensionToTheClass(), the extension is added to the context running in the browser by adding a file to _config, which gets cleared out after the scenario ends - but the extension is also added to the context running the tests via ::add_extension(), which was not being cleared.

This was fine in the past, because features that would have been affected were in one of two camps:

1. Weren't adding an extension in a scenario - only in a background
2. Fixtures were being created in the browser context or in a way that didn't trigger errors from extensions

This change swapped the context for the creation of SiteTree records in elemental features. This caused the new validation failed extension from silverstripe/silverstripe-elemental#930 to cause an error when a new SiteTree record was created.

We just need to clear the extensions from the test context after each scenario.

[emteknetnz]

Merged and released as 5.0.1