Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS 5: Ensure correct constraints for vendor-plugin and recipe-plugin before release #341

Closed
GuySartorelli opened this issue Dec 14, 2022 · 2 comments

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Dec 14, 2022

In silverstripe/silverstripe-admin#1318 we changed the constraint for silverstripe/recipe-plugin and added silverstripe/vendor-plugin as an explicit dependency of installer both with constraint 2.x-dev. This was to resolve a problem where the alpha release was being checked out in CI when we needed the dev branch.

When we do a release, we need to make sure the release includes the correct stability constraints for these. There are two ways to handle that:

  1. Make sure these plugins are handled by cow. Cow already knows how to deal with these constraints, so it just needs to know it is meant to handle the constraints for these dependencies as well.
  2. Manually revert these constraints to ^2 before we do a release. This solution is simpler but it runs the risk of the same thing happening to us again at some future point in time.

Note: also need to do the same for recipe-kitchen-sink (see silverstripe/recipe-kitchen-sink#26)

PRs

@emteknetnz
Copy link
Member

Chatted offline - we'll manually release 2.0.0 for silverstripe/vendor-plugin and silverstripe/recipe-plugin and update constraints to ^2

@emteknetnz emteknetnz self-assigned this Feb 7, 2023
@emteknetnz emteknetnz removed their assignment Feb 8, 2023
@GuySartorelli
Copy link
Member Author

All done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants