Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[worker] - Stop sending already-caught exceptions to sentry. Log them instead #30

Open
heysamtexas opened this issue Apr 17, 2020 · 1 comment
Labels
enhancement New feature or request worker The screenshot worker

Comments

@heysamtexas
Copy link
Member

We already catch webdriver exceptions and handle them. Sending them into sentry does nothing but confuse things.

This is a misuse of sentry. We should simply log these handled cases somewhere. Either log it as STDERR / STDOUT or just stick it in a database table and we can look at it later.

@heysamtexas heysamtexas added enhancement New feature or request worker The screenshot worker labels Apr 17, 2020
@heysamtexas
Copy link
Member Author

This also affects webhooks. The webhook should send back a status and the error message to the service that called it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request worker The screenshot worker
Projects
None yet
Development

No branches or pull requests

1 participant