Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Nepal example trajectory with something that makes more sense (and can be analyzed) #170

Closed
zven opened this issue Mar 17, 2022 · 6 comments · Fixed by #212
Closed
Assignees

Comments

@zven
Copy link
Contributor

zven commented Mar 17, 2022

At the moment, we have a rather large Nepal trajectory that can not be analyzed for inferences. Although the analysis is not important for the study, something that makes a bit more sense and is smaller might be beneficial (e.g. for explaining the basic functionality). Maybe we can re-use one the artificial test datasets that are used for the automated tests?

Mentioned here: #156

@zven
Copy link
Contributor Author

zven commented May 5, 2022

@JuanFFranco the script dev\generate_test_trajectory.ts creates a set of test trajectories based on the content of the test-data-gpx folder and stores them in a format that is then used in the automatic test execution (see package.json) and could be used to replace the nepal trajectory. If you are struggling with executing the script, please ping me. :-)

@JuanFFranco
Copy link
Collaborator

When executing the script, and try all trajectories generated, is not possible to generate inferences.

Screenshot_20220506_184816 Screenshot_20220506_184835

@JuanFFranco
Copy link
Collaborator

I created a new Trajectory, that when I import it, creates inferences with no problem, but when I replace the Nepal trajectory to this one, the app won't create inferences from it. I'm not sure if there's an extra step when importing the json file that does not occur when reading the example json file.

  • When replacing example trajectory:

Screenshot_20220527_190141

  • When importing trajectory:

Screenshot_20220527_190157

@zven
Copy link
Contributor Author

zven commented Jun 1, 2022

Idea for fix:

  • try to import example trajectory on app start into database
  • check on every start if it is already there

@JuanFFranco
Copy link
Collaborator

Only missing fixing the sorting of the trajectories in the Select Trajectory Page

JuanFFranco added a commit that referenced this issue Jun 27, 2022
JuanFFranco added a commit that referenced this issue Jun 27, 2022
@JuanFFranco
Copy link
Collaborator

Just realized a small flaw, if the trajectory is threated as a TrajectoryType.EXAMPLE is not possible to delete the trajectory, but as this new trajectory is still TrajectoryType.IMPORT, only with a badge that says example, it will be possible to delete it, but if the user does it, won't be possible to get it back.

Screenshot_2022-06-27-23-11-04-835_de ifgi simport learning

@JuanFFranco JuanFFranco linked a pull request Jun 27, 2022 that will close this issue
JuanFFranco added a commit that referenced this issue Jul 4, 2022
JuanFFranco added a commit that referenced this issue Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants