Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data race in sky socks-client #1923

Open
mrpalide opened this issue Jan 22, 2025 · 0 comments
Open

Data race in sky socks-client #1923

mrpalide opened this issue Jan 22, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@mrpalide
Copy link
Contributor

Describe the bug
A data race appears in skysocks-client after close it by UI

Environment information:

  • OS: e.g. Linux
  • Platform: Integration Env

Steps to Reproduce
Steps to reproduce the behavior:

  1. Run integration env by make integration-env-build
  2. Connect visor-c to visor-a as skysocks-client
  3. Stop visor-c skysocks-client app
  4. check logs

Actual behavior

[2025-01-22T12:10:32.789597919Z] DEBUG (STDOUT) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]: Listening skysocks client on :1080Closing proxy client
[2025-01-22T12:10:32.795201475Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]: ==================
[2025-01-22T12:10:32.797551321Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]: WARNING: DATA RACE
[2025-01-22T12:10:32.799798252Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]: Read at 0x00c0002d0d90 by goroutine 231:
[2025-01-22T12:10:32.79725295Z] INFO [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]: App skysocks-client is Stopped
[2025-01-22T12:10:32.797283908Z] DEBUG (STDOUT) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]: Error accepting: accept tcp [::]:1080: use of closed network connection
[2025-01-22T12:10:32.802276346Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/skycoin/skywire/internal/skysocks.(*Client).Close.func1()
[2025-01-22T12:10:32.811959185Z] INFO [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]: App skysocks-client is Stopped
[2025-01-22T12:10:32.821582859Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/internal/skysocks/client.go:191 +0xa4
[2025-01-22T12:10:32.823848914Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   sync.(*Once).doSlow()
[2025-01-22T12:10:32.826493132Z] DEBUG [RouteGroup rAddr:031b80cd5773143a39d940dc0710b93dcccc262a85108018a7a95ab9af734f8055:49164, lAddr:024ec47420176680816e0406250e7156465e4531f5b26057c9f6297bb0303558c7:3]: Got close packet with code 0
[2025-01-22T12:10:32.826599047Z] DEBUG [RouteGroup rAddr:031b80cd5773143a39d940dc0710b93dcccc262a85108018a7a95ab9af734f8055:49164, lAddr:024ec47420176680816e0406250e7156465e4531f5b26057c9f6297bb0303558c7:3]: Handling response close packet with code 0
[2025-01-22T12:10:32.826729795Z] DEBUG [RouteGroup rAddr:031b80cd5773143a39d940dc0710b93dcccc262a85108018a7a95ab9af734f8055:49164, lAddr:024ec47420176680816e0406250e7156465e4531f5b26057c9f6297bb0303558c7:3]: Remote got closed, stopping keep-alive loop
[2025-01-22T12:10:32.826794044Z] DEBUG [RouteGroup rAddr:031b80cd5773143a39d940dc0710b93dcccc262a85108018a7a95ab9af734f8055:49164, lAddr:024ec47420176680816e0406250e7156465e4531f5b26057c9f6297bb0303558c7:3]: Remote got closed, stopping ping loop
[2025-01-22T12:10:32.82619926Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /usr/local/go/src/sync/once.go:76 +0xac
[2025-01-22T12:10:32.82934443Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   sync.(*Once).Do()
[2025-01-22T12:10:32.831260615Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /usr/local/go/src/sync/once.go:67 +0x40
[2025-01-22T12:10:32.832880886Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/skycoin/skywire/internal/skysocks.(*Client).Close()
[2025-01-22T12:10:32.834483075Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/internal/skysocks/client.go:186 +0x7c
[2025-01-22T12:10:32.835898849Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/skycoin/skywire/cmd/apps/skysocks-client/commands.init.func1.1()
[2025-01-22T12:10:32.837989573Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/cmd/apps/skysocks-client/commands/skysocks-client.go:118 +0x40
[2025-01-22T12:10:32.838779939Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]: Previous write at 0x00c0002d0d90 by main goroutine:
[2025-01-22T12:10:32.839603387Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/skycoin/skywire/internal/skysocks.(*Client).ListenAndServe()
[2025-01-22T12:10:32.840398752Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/internal/skysocks/client.go:62 +0x174
[2025-01-22T12:10:32.841113993Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/skycoin/skywire/cmd/apps/skysocks-client/commands.init.func1()
[2025-01-22T12:10:32.841913067Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/cmd/apps/skysocks-client/commands/skysocks-client.go:132 +0x990
[2025-01-22T12:10:32.84288768Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/spf13/cobra.(*Command).execute()
[2025-01-22T12:10:32.843689753Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/vendor/github.com/spf13/cobra/command.go:989 +0xc18
[2025-01-22T12:10:32.84437062Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/spf13/cobra.(*Command).ExecuteC()
[2025-01-22T12:10:32.846576009Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/vendor/github.com/spf13/cobra/command.go:1117 +0x4bc
[2025-01-22T12:10:32.847270334Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/spf13/cobra.(*Command).Execute()
[2025-01-22T12:10:32.847919743Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/vendor/github.com/spf13/cobra/command.go:1041 +0x34
[2025-01-22T12:10:32.848545193Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/skycoin/skywire/cmd/skywire/commands.Execute()
[2025-01-22T12:10:32.849140686Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/cmd/skywire/commands/root.go:358 +0x20
[2025-01-22T12:10:32.849811178Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   main.main()
[2025-01-22T12:10:32.850533544Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/cmd/skywire/skywire.go:35 +0xfc
[2025-01-22T12:10:32.85122491Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]: Goroutine 231 (running) created at:
[2025-01-22T12:10:32.852000151Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/skycoin/skywire/cmd/apps/skysocks-client/commands.init.func1()
[2025-01-22T12:10:32.853171262Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/cmd/apps/skysocks-client/commands/skysocks-client.go:116 +0x760
[2025-01-22T12:10:32.855349443Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/spf13/cobra.(*Command).execute()
[2025-01-22T12:10:32.85638543Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/vendor/github.com/spf13/cobra/command.go:989 +0xc18
[2025-01-22T12:10:32.857169629Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/spf13/cobra.(*Command).ExecuteC()
[2025-01-22T12:10:32.857892245Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/vendor/github.com/spf13/cobra/command.go:1117 +0x4bc
[2025-01-22T12:10:32.858678819Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/spf13/cobra.(*Command).Execute()
[2025-01-22T12:10:32.859405435Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/vendor/github.com/spf13/cobra/command.go:1041 +0x34
[2025-01-22T12:10:32.860174592Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   github.com/skycoin/skywire/cmd/skywire/commands.Execute()
[2025-01-22T12:10:32.860995999Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/cmd/skywire/commands/root.go:358 +0x20
[2025-01-22T12:10:32.861885571Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:   main.main()
[2025-01-22T12:10:32.862690686Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]:       /skywire/cmd/skywire/skywire.go:35 +0xfc
[2025-01-22T12:10:32.86504949Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]: ==================
[2025-01-22T12:10:32.865853314Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]: Error serving proxy client: accept: accept tcp [::]:1080: use of closed network connection
[2025-01-22T12:10:33.828346207Z] ERROR (STDERR) [proc:skysocks-client:032b6d6f70fc4e4faedcbd3215e7056d]: Found 1 data race(s)
@mrpalide mrpalide added the bug Something isn't working label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant