From 6697c08145f340a8942b38c5760119429b06acd9 Mon Sep 17 00:00:00 2001 From: owen thomas Date: Thu, 5 Dec 2024 11:31:16 -0500 Subject: [PATCH 1/2] steo-issuer: Allow to set deployment strategy --- step-issuer/templates/deployment.yaml | 3 +++ step-issuer/values.yaml | 3 +++ 2 files changed, 6 insertions(+) diff --git a/step-issuer/templates/deployment.yaml b/step-issuer/templates/deployment.yaml index 2f9cf08..15a9ee5 100644 --- a/step-issuer/templates/deployment.yaml +++ b/step-issuer/templates/deployment.yaml @@ -7,6 +7,9 @@ metadata: control-plane: {{ .Values.service.controlPlane }} {{- include "step-issuer.labels" . | nindent 4 }} spec: + {{- if .Values.updateStrategy }} + strategy: {{ toYaml .Values.updateStrategy | nindent 4 }} + {{- end }} replicas: {{ .Values.replicaCount }} selector: matchLabels: diff --git a/step-issuer/values.yaml b/step-issuer/values.yaml index bb1b5ad..68a5c03 100644 --- a/step-issuer/values.yaml +++ b/step-issuer/values.yaml @@ -54,6 +54,9 @@ service: podSecurityContext: {} # fsGroup: 2000 +# Strategy used for the deployment +updateStrategy: {} + # security context for container securityContext: runAsUser: 1000 From 153a79ea081910e35ea10230de274dfeaa09b754 Mon Sep 17 00:00:00 2001 From: owen thomas Date: Thu, 5 Dec 2024 11:37:44 -0500 Subject: [PATCH 2/2] Beter variable location --- step-issuer/README.md | 1 + step-issuer/templates/deployment.yaml | 4 ++-- step-issuer/values.yaml | 5 ++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/step-issuer/README.md b/step-issuer/README.md index b60868f..731e191 100644 --- a/step-issuer/README.md +++ b/step-issuer/README.md @@ -52,6 +52,7 @@ and their default values. | `image.pullPolicy` | Step Issuer image pull policy | `IfNotPresent` | | `deployment.args.enableLeaderElection` | Enable k8s controller leader election. | `true` | | `deployment.args.disableApprovalCheck` | To disable cert-manager approvals on old version of cert-manager. | `false` | +| `deployment.strategy` | To change the deployment strategy. | `{}` | | `stepIssuer.create` | If we should automatically create a StepIssuer | `false` | | `stepIssuer.caUrl` | Step Certificates CA URL. This is usually the step certificates service FQDN. | `""` | | `stepIssuer.caBundle` | Step Certificates root certificate in a single-line base64 string. | `""` | diff --git a/step-issuer/templates/deployment.yaml b/step-issuer/templates/deployment.yaml index 15a9ee5..d1f12e3 100644 --- a/step-issuer/templates/deployment.yaml +++ b/step-issuer/templates/deployment.yaml @@ -7,8 +7,8 @@ metadata: control-plane: {{ .Values.service.controlPlane }} {{- include "step-issuer.labels" . | nindent 4 }} spec: - {{- if .Values.updateStrategy }} - strategy: {{ toYaml .Values.updateStrategy | nindent 4 }} + {{- if .Values.deployment.strategy }} + strategy: {{ toYaml .Values.deployment.strategy | nindent 4 }} {{- end }} replicas: {{ .Values.replicaCount }} selector: diff --git a/step-issuer/values.yaml b/step-issuer/values.yaml index 68a5c03..3569f4c 100644 --- a/step-issuer/values.yaml +++ b/step-issuer/values.yaml @@ -33,6 +33,8 @@ deployment: enableLeaderElection: true disableApprovalCheck: false terminationGracePeriodSeconds: 10 + # Strategy used for the deployment + strategy: {} resources: limits: @@ -54,9 +56,6 @@ service: podSecurityContext: {} # fsGroup: 2000 -# Strategy used for the deployment -updateStrategy: {} - # security context for container securityContext: runAsUser: 1000