Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(extensions.decompile) Titanfall 1 & 2 BrushSides #70

Open
snake-biscuits opened this issue Nov 12, 2022 · 3 comments
Open

(extensions.decompile) Titanfall 1 & 2 BrushSides #70

snake-biscuits opened this issue Nov 12, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request respawn.titanfall Titanfall branch script respawn.titanfall2 Titanfall 2 branch script Test Map: Tools: Radiant This test map can be built with a Radiant Fork

Comments

@snake-biscuits
Copy link
Owner

@F1F7Y over at MRVN-radiant/MRVN-radiant figured out plane indexing
Time to revisit brush slicing
https://github.com/MRVN-radiant/MRVN-radiant/blob/main/tools/remap/source/bspfile_titanfall.cpp#L607-L629

Also seems like the discard/ignore plane flags are linked to ray collision, but not player collision

Still doesn't solve model brush indexing for r2 so put in a lazy fix for that edge case so we can get sliced brush geo

@snake-biscuits snake-biscuits added enhancement New feature or request Test Map: Tools: Radiant This test map can be built with a Radiant Fork labels Nov 12, 2022
@snake-biscuits snake-biscuits self-assigned this Nov 12, 2022
@snake-biscuits snake-biscuits added this to the v0.5.0 milestone Mar 17, 2023
@snake-biscuits
Copy link
Owner Author

Brush planes in r1 & r2 have been covered pretty thoroughly in #81
Totally forgot about this issue, but it's pretty well solved now.
Still having some issues w/ matching brushes to entities in r2 tho.

r5 collision is a different story, see #7 & #85

@snake-biscuits
Copy link
Owner Author

Literally a week after I opened this issue: d55c962

Could probably be better tho tbh.

Might be missing some facet of excluded planes.
IIRC some planes can be facing away from the brush origin.
planes.py was part of r1/r2 brush-plane research IIRC, but that's about to move to bsp_tool_examples as part of #88

NOTE: future research experiments should move to bsp_tool_examples or tests (tests.branch.TestTheories)

@snake-biscuits snake-biscuits changed the title [extensions/decompile_rbsp] revisit plane indexing [extensions.decompile_rbsp] revisit plane indexing Aug 13, 2023
@snake-biscuits snake-biscuits moved this to Todo: Code in bsp_tool Extensions Feb 6, 2024
@snake-biscuits snake-biscuits moved this from In Progress to Todo: Code in bsp_tool Format Coverage Feb 6, 2024
@snake-biscuits snake-biscuits changed the title [extensions.decompile_rbsp] revisit plane indexing (extensions.decompile) revisit plane indexing Feb 7, 2024
@snake-biscuits
Copy link
Owner Author

Currently revisiting BrushSideProperty.flags
BrushSideProperty is a BitField now

Made a new respawn.titanfall.brush method as a part of:

This method includes the flags in BrushSide.flags (not shown in repr or annotations)
I want filtering out culled BrushSides to be deferred, so we can use the brush method to pull out all the sides
Makes debugging way easier

@snake-biscuits snake-biscuits changed the title (extensions.decompile) revisit plane indexing (extensions.decompile) Titanfall 1 & 2 BrushSides Feb 8, 2024
@snake-biscuits snake-biscuits added respawn.titanfall Titanfall branch script respawn.titanfall2 Titanfall 2 branch script labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request respawn.titanfall Titanfall branch script respawn.titanfall2 Titanfall 2 branch script Test Map: Tools: Radiant This test map can be built with a Radiant Fork
Projects
Status: Todo: Code
Status: Todo: Code
Development

No branches or pull requests

1 participant