Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks to CI #281

Open
snowleopard opened this issue Nov 14, 2021 · 2 comments
Open

Add benchmarks to CI #281

snowleopard opened this issue Nov 14, 2021 · 2 comments

Comments

@snowleopard
Copy link
Owner

We used to have benchmarks running in CI on every commit, which helped us to catch performance regressions. This functionality was initially implemented in #82, but I accidentally dropped it when migrating CI to GitHub Actions in this commit.

The benchmarking script produced a performance summary for a few Algebra.Graph functions, like this:

addEdge: 1.10 (OK)
addVertex: 1.10 (bad)
dff: 1.00 (OK)
edgeCount: 1.00 (OK)
edgeList: 1.01 (OK)
edges: 1.06 (OK)
equality: 1.00 (OK)
hasEdge: 0.97 (OK)
hasVertex: 0.99 (OK)
isEmpty: 0.92 (OK)
reachable: 1.00 (OK)
removeEdge: 0.96 (OK)
removeVertex: 0.83 (good)
topSort: 1.01 (OK)
transpose: 1.04 (OK)
vertexCount: 0.94 (OK)
vertexList: 0.98 (OK)

It would be great to restore this functionality. The benchmarking script itself is still available here, although it might require some refreshing.

/cc @cyoon1729 who was interested in helping with this.

@cyoon1729
Copy link

Excited to look into this!

@snowleopard
Copy link
Owner Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants