Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scarb doc should not document pub(crate), as it's not part of public package API #1785

Open
maciektr opened this issue Nov 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@maciektr
Copy link
Contributor

Problem

Currently, scarb-doc does not generate docs for private package items (

fn ignore_private_items_with_new_edition() {
). However, pub(crate) is also not accessible through the package API, thus it should also be skipped.

Proposed Solution

No response

Notes

No response

@github-project-automation github-project-automation bot moved this to Triage in Scarb Nov 27, 2024
@maciektr maciektr added this to the Scarb Doc milestone Nov 27, 2024
@maciektr maciektr moved this from Triage to Backlog in Scarb Nov 27, 2024
@maciektr maciektr added the bug Something isn't working label Nov 27, 2024
@maciektr maciektr moved this from Backlog to Todo in Scarb Jan 14, 2025
@maciektr maciektr moved this from Todo to In Progress in Scarb Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

No branches or pull requests

2 participants