Response with request tags

[sergio-margale]

In order to differentiate sttp prometheus metrics by external service I used to tag the request with the name of the external service, so then when creating the PrometheusBackend I could get the tag from the request and add it to the metric as a label.

my_service_sttp_requests_success_count_total{service="my_service", service_name="external-service-1"}
my_service_sttp_requests_success_count_total{service="my_service", service_name="external-service-2"}
...

Since 3.5.0 that's no longer possible for all metrics, as now responseToSuccessCounterMapper and responseToErrorCounterMapper are based on the Response.

Is there any plan to maybe add tags to the ResponseMetadata? Or is there maybe another way to achieve this?

[adamw]

Adding tags to Response would be tricky, but maybe we can extend RequestMetadata with tags so that Response.request would make it possible to read that. Maybe you'd like to attempt creating a PR?

[sergio-margale]

Tbh, I'm not sure if I can do it anytime soon

[sergio-margale]

I found 5 mins to at least do the first step :) softwaremill/sttp-model#189