Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all internal plugins inherit from plugin base classes (and optionally extract) #305

Open
sdruskat opened this issue Jan 14, 2025 · 0 comments
Labels
architecture Describes some architectural decisions that need to be made enhancement New feature or request meeting-discussion Issues that should be discussed at the next project meeting
Milestone

Comments

@sdruskat
Copy link
Contributor

Currently, some internal plugins don't inherit from the plugin base classes, e.g., the Invenio postprocess ones.

In the interest of dogfooding and consistency, all plugins should inherit from the respective base classes IMHO.

Optionally, these plugins could also be extracted into separate repos, although I'm not fully convinced that this is necessary.

@sdruskat sdruskat added enhancement New feature or request meeting-discussion Issues that should be discussed at the next project meeting architecture Describes some architectural decisions that need to be made labels Jan 14, 2025
@sdruskat sdruskat added this to the 0.9.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Describes some architectural decisions that need to be made enhancement New feature or request meeting-discussion Issues that should be discussed at the next project meeting
Projects
None yet
Development

No branches or pull requests

1 participant