Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolusIO module intercepting upgrade orders #51

Open
mrtimp opened this issue Mar 31, 2021 · 5 comments
Open

SolusIO module intercepting upgrade orders #51

mrtimp opened this issue Mar 31, 2021 · 5 comments

Comments

@mrtimp
Copy link

mrtimp commented Mar 31, 2021

Hi there,

The AfterProductUpgrade hook in the hooks file:

solusiovps/hooks.php

Lines 15 to 17 in e97c096

add_hook('AfterProductUpgrade', 1, function (array $params) {
Product::upgrade($params['upgradeid']);
});

seems to be intercepting all upgrades created via the client area even if they are for orders that do not relate to products using the SolusIO provisioning module and causing the following error:

1d6718ce-a722-4692-9e95-a7e60572a495

This functionality is currently blocking our ability to use this module as it blocks the ability to upgrade/downgrade other product types.

I'm picking a fix would be additional checking in WHMCS\Module\Server\SolusIoVps\WhmcsAPI\Product::upgrade to only perform the resize if the product uses the SolusIO provisioning module.

@redikultsevsilver
Copy link
Contributor

Hi @mrtimp , thank you for the bug report.

I have submitted a a task to fix it in one of the upcoming releases as it looks like a blocker to me. Task ID is SIO-3409.

@mrtimp
Copy link
Author

mrtimp commented Aug 4, 2021

Thanks @redikultsevsilver, if you like once its resolved let me know and I'll update the version of the SolusIO module we use and do some functional testing :-)

@acidmk
Copy link
Contributor

acidmk commented Sep 22, 2021

#62

@redikultsevsilver
Copy link
Contributor

Hi @mrtimp ,
we have released the new version of SolusIO vps module where the issue with module intercepting the upgrades should be fixed: https://github.com/solusio/solusiovps/releases/tag/v1.2.7

@mrtimp
Copy link
Author

mrtimp commented Sep 22, 2021

Thanks @redikultsevsilver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants