Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make soft/optional dependency for Templating component #221

Closed
Koc opened this issue Aug 26, 2015 · 4 comments
Closed

Make soft/optional dependency for Templating component #221

Koc opened this issue Aug 26, 2015 · 4 comments

Comments

@Koc
Copy link

Koc commented Aug 26, 2015

Starting from Symfony 2.7 we can use twig directly without templating component. It could also improve performance a lot. But SonataBlockBundle has hard dependencies for this component and prevents disabling templating subsystem.

@soullivaneuh
Copy link
Member

Do you have some docs about it?

Also feel free to propose a PR.

@Koc
Copy link
Author

Koc commented Aug 26, 2015

@covex-nn
Copy link
Contributor

@soullivaneuh this issue is not outdated, even after 2 years.

Well, for the templating part, the admin bundle should rather migrate to using the native Twig notation for templates, and using the Twig service directly. We precisely want to discourage the usage of the Templating wrapper in Flex projects.

(c) stof symfony/flex#247 (comment)

But to do this, second argument of AbstractBlockService::__construct must be changed from EngineInterface $templating = null to \Twig\Environment $twig = null. This is a lot of changes in all sonata-project bundles

@Koc
Copy link
Author

Koc commented Jan 21, 2018

ref #456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants